[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: cpu{id,}_policy_updated() can be static
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Apr 2023 12:22:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/fdHGOELZfMAL7Kk0jxADdmkjbHVsTQAjBTablrwl60=; b=Mzd8Lzq81GTkiHs8J7qfTj/LKYkukeCnIpR87Ufeez4dyBJbitMbVRC93/IMGKAG0vOet5HSIRC7y4N9y2NwNrp9jVCaRpKlYFzeZ/0ll2lXadJgIORmubzHn4gOU82cnrmEQbm83q4epzK1jzm8RQ7NrLRvRovYb5qHVWQLRDHKQQYIANA2vq+uu7OxdRYxFRKPw05XfVrkmY+U49+uRD8N6STsVAFUFi0aFgsB9n8/ML1w4oz92zYc4s/mFLl87Zwx+GEM88BolzzqWvy3vr5fEdaRMcooIZ97caEF7zbARrLqE0VrxI4PkfLqL0ZriJ5wC1YnEPTDnpcFqRHLJg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOsi0yy7lOhmxstAYj3fg49KJ9Fbaq8ekvTHFXEdMbPSgkCu768OkNfT46IbCCI5+HAMCufGZWlr+fzCBq+I2hY9KcCfmcdatvRVYSezXUjniY52mYFWLHggZe6MidxWTwv8ybLvxOQawt6lKCEa6SAH+dkldsCNlp6Eduo7F60cT7Lzk0SCqgQ86fHd1cT8gnbx5yWBpXjJ7/HltPm/aBqNHI2UdJjZk6Gm+sGKDk+/hZc5HC2foLYxbO9BsPQ66dKLGltItXUrJXS5Pb8Vqq6fz+zTJLCJBWkzaV82BjVWlme5UnXejJnDP7YSMl2WlVg4CeKjbB6yWINB+5xjLQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 18 Apr 2023 10:22:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.04.2023 11:42, Roger Pau Monné wrote:
> On Tue, Apr 18, 2023 at 11:35:41AM +0200, Jan Beulich wrote:
>> The function merely needs moving earlier in the file to avoid the need
>> for a forward declaration. While moving it, also rename it following the
>> recent folding of CPUID and MSR policies.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks.
> We might also want to rename the hvm_function_table hook.
I did notice this, but it seemed orthogonal enough to not do it right here.
> One minor comment below.
>
>>
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -288,6 +288,16 @@ void update_guest_memory_policy(struct v
>> }
>> }
>>
>> +/*
>> + * Called during vcpu construction, and each time the toolstack changes the
>> + * CPUID configuration for the domain.
>
> The comment also needs to be updated to contain CPUID/MSR or some
> such now.
This isn't the case just yet aiui, but will be soon. Saying something
like "MSR configuration" would read misleading to me, so I'd prefer "CPUID
etc configuration", if that's okay with you (and Andrew).
Jan
|
