[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: cpu{id,}_policy_updated() can be static
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 18 Apr 2023 11:42:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0AIfNzysz2UKvwfdQdACRz8x/Ch40xI0zk4GKK/TY0A=; b=fgrN4YbF+X9t0l6aH7+ALJhPP5S6ORTkVh3Pi3XT+G1WGymggCZKB6ZENXfV8o4U+emiXrxTMcbSLEdYwvPbbl1Xa4UPhCRbC5pZ70IJmXKjyNei8H7qezLMGTQEjBByE4ZDZjo+8cljzKY5h697FxecFcR4PO+cpTvdwFv8CrRkTXdRm14o4E7Vl9jwmcBuLoV4WV6uFcn5+viCrdm/NHc9yB52ou3ii8l9JHUBRiFtOLfXdLjXf5gU9HzwFrXOIIe50omtvh7ufpxEr99Mr4Da/5Evr5+Gdk9pm5NDahtFwxGFvUZER88qR5D+d61w2OWYKD7DKOyrgzMVlTf0qA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5HCY8kGzAoHKtxsj28D3b7ymECnzOp3gNkIK+ieFfnak/pmCUOGDSFYymTPYh3SnL608bgRv2x7gWJDmXv+xdS38wwBJYFathg/eLJzSJ9cDLinvlWDby4MdWSga2M65mYb9XXY7jmfJ7H6Kre2YQjBvza8yMXNju5/wk7NUUSEAH86RETmpOZZdeOjlY5SV86yEps3BykblQvDRzcZsUzfCVoNsJiNE8fia7lyG7d48OXAg7zux1EURwTr6lpRKu7ZfphW5tsLz5lso6qkTs34EE+7rMQOoCLaxzODDwPb5Oc6rykuSdC36jHb2M7gjzJWW2zbByVxFFMf28D/9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 18 Apr 2023 09:42:47 +0000
- Ironport-data: A9a23:OmykAKthamUYH1KUxUq73+W0ZOfnVHBfMUV32f8akzHdYApBsoF/q tZmKW2EbPiNMTCneY10YY6wp0oP75HXz4JgHlM/+S9jQS1H+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AOHxyFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwGh4dRyqvjOOKnInmVuhO3u47LOL1BdZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60boq9lt+iHK25mm6Co W3L5SLhCwwyP92D0zuVtHmrg4cjmAuiAN9IS+HoraQCbFu7+XFDBjYpdH+CjfChuFafUIN6E 3AQw397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRVLufgcBRAoBptXm/oc6i0uVSs45SfDlyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CBhRqcBO51lmW8g UU=
- Ironport-hdrordr: A9a23:DSNR7a9FlyEUfUm70MBuk+D+I+orL9Y04lQ7vn2ZESYlFPBxl6 iV/MjzpiWE8Qr5OUtQ5OxoXZPqfZqyz+8Q3WB8B9mftWrdyReVxeNZnOzfKlTbckWSmoFgPM 9bAtdD4bbLfDtHZLPBkWyF+qEbsbu6Gc6T5Ns2yU0GceggUdAZ0+4wMHfhLqRZfng9OaYE
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 18, 2023 at 11:35:41AM +0200, Jan Beulich wrote:
> The function merely needs moving earlier in the file to avoid the need
> for a forward declaration. While moving it, also rename it following the
> recent folding of CPUID and MSR policies.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
We might also want to rename the hvm_function_table hook.
One minor comment below.
>
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -288,6 +288,16 @@ void update_guest_memory_policy(struct v
> }
> }
>
> +/*
> + * Called during vcpu construction, and each time the toolstack changes the
> + * CPUID configuration for the domain.
The comment also needs to be updated to contain CPUID/MSR or some
such now.
Thanks, Roger.
|
