[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/cpu-policy: fix "run" goal
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Apr 2023 11:38:48 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogWMwPoSbDuqivXYfjPwTOM1RRjb8h/Lr4C9H5qDfA0=; b=YtqnNDnvSYCc4i4G7b1i0vUCv/HlX1ImVn9C/Tj/4ey2fRrYM6OSqa1xeF9hylGEFqnBi75yVGc5BgG3CkH5azAVbP6N1e9jX/dvQOqV3BTlZEoUKFraPNqNuKeCjsoARWQEbPl6mN+z/YFQehckogAKVvK+MAh5uzr+DpqVprr4e8B+lVXW+fbA8EhIGUsCM03pxBn8Neih2FrJOZ29kjtLX8UHko5fzYmoRLjcoF7SgAk//WO1/u1Xh0/aJebmfiXlWxCB21HLNZTPHj6vZePW3abeLDUvGmmzX72TX/ZK06QHYK1QfCtTEimRKoI/TL0bqHtMqBqxzSr1vQLX9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Io/nFooOfPPrvrhKn907vYbM3DzY7PrjLYC0NU6ib35DWduhBUh9BsPSStxndLEVTBj+1OgkwXTEOD99xWKh66M4H31e+hJnvxUrWvkOFOQ3G0GXq1V3XWV9kryH1WtJWTY+fng5YCR/Xj4iVjgy8NYroNjN0Noo+Bi99iWK89DPM+2z7OHMVeKYHdMQfM+EcY+i/7+gTcLDnMXY20E8Pl12XUf1zpDsfE0wAPIfJ1EK3MgbSz+Vn4Lev1qfi5b5cXkzZYDu4DQjYuKU3A9eyyCm9//+kLV1cCfjVa4WneE0iuEl2g4VN83MhNW5sVLGITMeLk12MRDteLnejWG0mg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 18 Apr 2023 09:39:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.04.2023 11:30, Roger Pau Monné wrote:
> On Tue, Apr 18, 2023 at 11:01:56AM +0200, Jan Beulich wrote:
>> An earlier change converted TARGET-y to TARGETS, but failed to replace
>> all references. Convert run's dependency, but use $< in the command to
>> avoid the leading blank that += inserts.
>>
>> Fixes: 6a9f5477637a ("tests/cpu-policy: Rework Makefile")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/tools/tests/cpu-policy/Makefile
>> +++ b/tools/tests/cpu-policy/Makefile
>> @@ -16,8 +16,8 @@ endif
>> all: $(TARGETS)
>>
>> .PHONY: run
>> -run: $(TARGET-y)
>> - ./$(TARGET-y)
>> +run: $(TARGETS)
>> + ./$<
>
> Since it seems like TARGETS can contain multiple outputs, do we want
> to have a for loop here?
Imo TARGETS is just the conventional name, even if it expand to only
a single target. I'd prefer to stick with the simple rule until such
time that there really are multiple executables here.
Jan
|
