[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/cpu-policy: fix "run" goal
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 18 Apr 2023 11:44:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=en1PDyDiRCEyYYwQMj/IFqRb6BrIjBNL8WfzdWZMF4I=; b=CYY9z33hVf1Xg/hf7qLu/4/f8hQ6LC9lpAiAi++7P2a8CZ3JVTJLJoTkG4CVyQmXzv+5R/p40SJ+saLYIj34ZwwJeeTpAt/Z2q4nROeBjDaIW++SeEKmQoBp1KZQHxanYdQa51FBpaJ6e1hi+EUYDHZb8lAo52z6/op4ebeenD2GHqe9Lm8wWRS/ZxXe7waPYdwFcVvAcL6KYfm6lKdvU+UUEqlPazzIxUnfhJ02N5QCDoG4vbgnSOUj8y3zPQYu7Vq8dB06Mmq6l2tj3h4MqE47WrSGKERyBPPTW93nNy9VkcoJpS1yQib18ds9nOJkeL9DiDiekj6olqV3xFf2uw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gHDQs0yV4rtmOcLp2fkxL7t60kpUsa+N6zRPTuoR3vXNv7FJuRZjs7G2nNSYO6VplGxm+7PdL251krJlCLdmPUMasZxUuwg6S//U+KBuK86VvVn8KoFiFoyrnfUY51MaufTgCMtzqbk9Ht6PqSzTPm7JC4VfHdShp3qHL2K72TvtoZL090DrjJnt6VG2w8ZdWEmKW8T+HOV8WHWqv3ymAw34V5vZTsUp2E61mSKmpJj6ltjpzQdYpxTCzr4uS2K+i6hYhxGppxEPvTiF3dstprYDfyxslxuCR4yvQplS7H7FkqikYCc0DbEf96QyVin4ZnHzsaX8+i1Ksui6Pqg25g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 18 Apr 2023 09:44:36 +0000
- Ironport-data: A9a23:c1X5RqzF0KMDbQFgAoZ6t+cRxyrEfRIJ4+MujC+fZmUNrF6WrkUPz GoZD2DUOvqON2P8f95wPNnkoxkHuZOHxtQwGldk/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UIHUMja4mtC5QRiPKAT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUxur KZGFSwtVDSSv+CXg5SGYa5l2dt2eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVMquFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37eTwnurBdlNfFG+3tRq2HOXz2gdMyMPb3ai/eS61heUf+sKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluP1TM9KGYDYWoBUlED6ty7/IUr1EuQFZBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPuRENXCzAS58Ebuk
- Ironport-hdrordr: A9a23:sRQrmqsv51BkeBPvt9GZ1mzR7skDhtV00zEX/kB9WHVpm6yj+v xG/c5rsiMc7Qx6ZJhOo7+90cW7L080sKQFgrX5Xo3SODUO2lHJEGgK1+KLrwEIWReOlNK1vZ 0KT0EUMqyUMbEVt6fHCAnTKadd/DGEmprY+ts3GR1WPH9Xg6IL1XYJNu6CeHcGIjWvnfACZe ChDswsnUvYRV0nKv6VK1MiROb5q9jChPvdEGM7705O0nj3sduwgoSKaCSl4g==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 18, 2023 at 11:38:48AM +0200, Jan Beulich wrote:
> On 18.04.2023 11:30, Roger Pau Monné wrote:
> > On Tue, Apr 18, 2023 at 11:01:56AM +0200, Jan Beulich wrote:
> >> An earlier change converted TARGET-y to TARGETS, but failed to replace
> >> all references. Convert run's dependency, but use $< in the command to
> >> avoid the leading blank that += inserts.
> >>
> >> Fixes: 6a9f5477637a ("tests/cpu-policy: Rework Makefile")
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >>
> >> --- a/tools/tests/cpu-policy/Makefile
> >> +++ b/tools/tests/cpu-policy/Makefile
> >> @@ -16,8 +16,8 @@ endif
> >> all: $(TARGETS)
> >>
> >> .PHONY: run
> >> -run: $(TARGET-y)
> >> - ./$(TARGET-y)
> >> +run: $(TARGETS)
> >> + ./$<
> >
> > Since it seems like TARGETS can contain multiple outputs, do we want
> > to have a for loop here?
>
> Imo TARGETS is just the conventional name, even if it expand to only
> a single target. I'd prefer to stick with the simple rule until such
> time that there really are multiple executables here.
Not specially fuzzed either way, and it's certainly an improvement
from the current status:
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
