[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 00/12] SVE feature for arm guests


  • To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 18 Apr 2023 13:13:26 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HwSVKbIMzh3zCXI0VqAxwpS+XOYQ+lgS1cyfBJWwROA=; b=Ibw6VRoOWcWg1G2FpbZuUeLeeW6q8UEm45BLADj+bCzny6rxP42nK/oK8j2rtZGG9vo04q1Z8OxIaV/rj3+x3r/BAV9NMUDQDvPFTJkdgm22dkB9QFNQG61V1gvR7msM7TmOj667mUf7cjIR5UvvDM3g9OD7I76i+DL4v/lKcvL0rCp+mbbG5h3HbXm3bCnOkTSSPo6Q141/RsJ111JEkNqy4iJAE8Kh8NlGdRhJAE0k+7KsWx1I9/k4iDe4Ly4VKDI613NWaem3holQx+ql9tGulmAJef0DpDtdbAQMMrdl/0x9witpoYy3DBWNRMHECEy7jAuAXm7Fn82pULvXTA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lhL5BilqVpf1o0HhIxUONS8pqNzz68nbg5wZlYwlfRhGPfwVy7CUl9Np5GKfIrVsdKzKBhkL+hs55LXUvLAlp6mBW1H0TI/08A8b6ajm/E97n4dgte+qLx31e0ydDZYGe5r3o1W2iwZTDPYU1pCjz79PZqt+ntgu8A10RANniobdi40xxdosj1da9FqPS7l3xAjI8gAkH3w3RwzlcKNOhNF5LJ0iA3G3iwTYTAoyyHT4vuh/1+XJekfc6z2R65lQBwksyerXeEfRzFgP52nJxRSsvBpZU+MxRLDCtRyBlpniwqjyLFVE7OmC9ba3Vt46KmQKRvEjNWbPc/UNB9whXQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>
  • Delivery-date: Tue, 18 Apr 2023 13:13:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZbSQqKlfgrZX3xkqta7+H+1gq3K8xFMoA
  • Thread-topic: [PATCH v5 00/12] SVE feature for arm guests

Hi Luca,

On this serie I would like to open a discussion on how to handle the vector size
and the corresponding command line / configuration / device tree parameters.

In general the user must either give a vector size it wants or has a solution to
just request the maximum supported size.

In the current implementation if a size bigger than the supported one is 
provided:
- we silently disable SVE for dom0
- we silently disable SVE for dom0less
- we do not create a guest when done through tools

This is not completely coherent and i think we should aim for a coherent 
behaviour
unless we have arguments for this status.

Is there any good reason to silently disable for Dom0 and dom0less only ?

I see some possible solutions here:

- modify parameter behaviour to use the supported size if parameter is bigger 
than
it. This would at least keep SVE enabled if a VM depends on it and could 
simplify
some of the handling by using 2048 to use the maximum supported size.

- coherently stop if the parameter value is not supported (including if sve is
not supported)

- always disable SVE if the parameter value is not supported.

To be honest I am not quite sure which solution is better but I am not happy 
with
the different kind of behaviour we have right now.

What are your thoughts ?

Regards
Bertrand




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.