[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 18 Apr 2023 13:16:03 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j0ff2h2XgdtvjQKzZ02iKbqHkgDXfbLwDdKltdkduoo=; b=YyI+Q+/LxfcX6zP6RYuP7c3i+4gAM9++1CEBLozvI/Bh2MI7WJzsJKYTqYFl9hp/JcV1GuXZ4nmHhrlYOIo6SnBj4oS8+ljdWhPy9b9Z41IxKnSvcfmPKtuxSDCUId7AueekPcZeFQ+KC/SznwIy0I19jNGLydQS1SC4AdJAGLrRkg7bud5U8hVkerrjmi45HEELGREybsAQFNGZ71o/ABAARqk1obuBYgB1cK6ldXU3hcwxLBCusQwDC6CyuD6F9hx9njbSk9XrzmzpbQkpcLwaNMKCb8WmVNM2uoooz05TTUYNUg80CLclU5SrgVANXOTj7lIz77gqtGcor2w8cA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AmVf/P1vW0tDnm7rJHo0pc6Lb+XwmMXU6AgIOhN0LRizbaT8h3xrcKoTM7ds29OVN17D6OSxkNxyiwoCRf0gOtLmvjLtB5B2ZMAqGo+O3CTwa4J8laeJALD0DIoD3NcOn5iGH8udmQ6O4n/statFmWjjSSZE3zZjAZ5jyyAmhv3zJ8obq+b/5yPHKGIe9adcBhpNpyUXgDzHOUgTCXFE4R8KrAJKRSVIQ7Zu40QE5vQIIuSdKaPqGfn70OSDl/0rS2CeLhfcRM3TezD26NG8V8jEnD08F+laxBkJOlZiEDUXcyjKwMYYWtLs2ENWh4iv5m/grQLmVO04YrTtTJuL5w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Community Manager <community.manager@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Apr 2023 13:16:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZcfQO8iHeqtg3REq5C5iSSt7pEa8xCqxw
- Thread-topic: [PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes
Hi Roger,
> -----Original Message-----
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Subject: [PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option
> changes
>
> Note in the changelog that the purpose of
> gnttab_max_{maptrack_,}frames command line options has been changed.
Thanks for remembering this!
>
> Fixes: b2ea81d2b935 ('xen/grants: repurpose command line max options')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> CHANGELOG.md | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index c978cfd9b68f..2a7e62495104 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -14,6 +14,8 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the
> system
> wide impact of a guest misusing atomic instructions.
> - xl/libxl can customize SMBIOS strings for HVM guests.
> + - Repurpose command line gnttab_max_{maptrack_,}frames options so
> they don't
> + cap toolstack provided values.
However, seeing the title and the "repurpose" here, may I please suggest
adding a "### Changed" section on top of the "### Added" section and
move the "gnttab_max_{maptrack_,}frames option changes" entry there?
I think this can be done on commit if you agree (and also the committer
would like to do the favor for us), so:
Acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
