[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tools/xenstore: fix quota check in acc_fix_domains()


  • To: Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 24 Apr 2023 10:56:15 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUR7VBKP8MkHieaWObt6DqrogvsLb6Z21kgjmVcVdF8=; b=NZjltycKdLMyJ/8paBcHrf9b7lVYapmNoRhCUThovlq5hdLyy4PJQvD+YhlSVvIe6Pkp6q3ZLzqgV2KzEF7kS+tFCnZC/B+Tg14iFprTVsubLqYmpmF8riCPvv+eiwYet3rMQhZs3Wnjl9ZHmyQoYFPKjG3m3Us6y79YYRXRhFP29C9pZb+BTT/CKMOuYbHZ/ehfzF0pe2SmoG29FlYYVX3It1OrwCPfp1itx0D2DtRvgDENDkwWl8+JXFTCHbjpMbvoOOk6skVFlEMx54Ku8n3nZPeDI69gPRbEu5CAOALvceUY3274ATlxOhGmEaC08JwbEOUelXviBVR22RHzBA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BodDJAi6H/4HBIVBsXedY8Dbf64TBWRNwa5cdgcqdvbC2CbV4oySmpttPHjjAU8w84Szxj0QK5qwvregl/n8UxR3zu2wm+T7Ojp6lnuIbdi1ZxyWlK8sbWuNylrOtCOw9LVh78QdWChX03uRuXwTgsoo3GEZ6BDHGsdfpqJfYVuaaiRKxfFIZWY3V6+I4l9hemkxCBRaAtO3qrZOnZWJOPyOZtQY1mTnAtu/ykojARha+KZRnmNwwGkA4LwxJ5zFDqIqA9UEvMea5Y5Mf1KQt5uT2QDmaowI3YMl/XFanSoM8cuIoMRQzzPJXc0/vV0q8rU4yR+Zmtf6F6FfJ4K5+g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 24 Apr 2023 08:56:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.03.2023 16:43, Juergen Gross wrote:
> Today when finalizing a transaction the number of node quota is checked
> to not being exceeded after the transaction. This check is always done,
> even if the transaction is being performed by a privileged connection,
> or if there were no nodes created in the transaction.
> 
> Correct that by checking quota only if:
> - the transaction is being performed by an unprivileged guest, and
> - at least one node was created in the transaction
> 
> Reported-by: Julien Grall <julien@xxxxxxx>
> Fixes: f2bebf72c4d5 ("xenstore: rework of transaction handling")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Considering the referenced commit is about 6 years old, I thought this
would be a backporting candidate. The function mentioned in the title
doesn't appear to exist on 4.17, though. Therefore, if there is an
intention for this to be backported, may I please ask that a suitable
backport be provided?

Thanks, Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.