[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/7] tools: Make some callers of xc_domain_getinfo() use xc_domain_getinfolist()
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 28 Apr 2023 13:21:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=11oaI3nPUD3u3AnIH+q8E2vEmJZI4B/jcKW+/7AaCfQ=; b=RdqWZwoFN1oLitZyi8a15YteMjPTN151P/UQU8SNlXwlxod8bm2B1mz3cpE8JMbwOcxWVTSN7y2xUvTfIPoRykE5aUzOK8jfylKnvwtRRn9Q/YcK2GyyUvLGUJmcJIdHbmi3YpVakzFWoUYdy1JF3C7dSlTNeCEh5Mrbt0NUGqa0yepGtxlRuEMIvDn361MuEcZDAOsuxbjYn0cVAggKMHCOWRjrYzaoTljH1dZw1ixtkI/jzhIVPxLocjzlM9dOyQYBqFq4srMp8H0c5ztK1fBBiJgBB2ZpFAmxeyA77uUBR4ss5mn3iXRAMbiAyig40mjVpfG86U0kK+4yAvF3gQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZARcrrNsSpOaAi/TWOFQ2dJ68aQcnDrioh1yFlS0Nv3xMO0YhuPWIL5LsdYjrdI6uw7SYDTAb+1RF8GH8x6kOT6EwMdxBbvfNYLdo2tv7E33aaTCsYKmRle13lf6mMLAbbX9EthX5c5wfuhRvPEyi3jonQfy0Vcrr3H+zbvr6F/dLN3TkARLMPSfiJ5hZApV0eRel1r199w+5MrDKT6t4rCkXNPiGEvzCnH3gHSn2d5s+Zrpc3KjkgqP2BYAIT3mfDwE9scQtiWibSpA4jsL+oHCw/4xkpxOodQ1usZwWBesZs/OcCsNyQKnRvMjKbmFjspVqT96sGXhquU7GtLvA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Fri, 28 Apr 2023 12:22:06 +0000
- Ironport-data: A9a23:viHQkqtDheru81DCgqbTz6P4QefnVJBfMUV32f8akzHdYApBsoF/q tZmKTuFbKneMWX0e9glatvnphwOsJTRmIVnSFdrqSA1RXsQ+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AOExyFJZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwJxEcahrSisaMx+iyVbZ+gsosfZbyM9ZK0p1g5Wmx4fcOZ7nmGvyPzvgBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjv60b4O9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqaAz3w3JmAT/DjU7dnyXgPa3q3WMYOtFI kZP0S0ytIUboRnDot7VGkfQTGS/lhcYVthZFeEg70eTw67Q7gSeLmMASSNNLtchsaceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcbSSMV7t+lp5s85jrNQcxkC7WdlcDuFHf7x DXikcQlr7AajMpO3KLi+1nC2muovsKQEVdz4RjLVGW46A8/fJSie4Gj9Vnc67BHMZqdSV6C+ nMDnqBy8dwzMH1ErwTVKM1lIV1jz6/t3OH06bK3I6Qcyg==
- Ironport-hdrordr: A9a23:wAMqpaM7RNuJlcBcTw/155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN93YgBGpTngAtjlfZq4z/JICOYqTNWftWXd2FdAT7sSlrcKoQeQYxEWn9Q1vc kAT0EXMqyIMbEQt7ee3ODXKadC/DHRm5rY49s2gk0dPj1CWuVF1UNUGwybGkp5SE1vAoc4Lo OV4o5iqyC7cXoaQ8ynDj1dNtKz0uHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G DZm0jS57mlsdu81hjAvlWjnah+qZ/E8J9uFcaMgs8aJnHFjRupXp1oX/m4sDU8sIiUmSgXue iJhy1lE9V46nvXcG3wiwDqwRPc3DEn7GKn4UOEgFP4yPaJDQ4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn93d7VTBtn/3DE10bKqdRjxEC3bLFuIoO49eckjQ5o+dY7bVXHAbkcYa FT5Jq23ocbTbuYB0qpwVWHjubcEUjbJS32PnTqivblqQS+o0oJsnfw5PZv70vop6hNO6Wsod 60RphVqA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/04/2023 11:41 am, Alejandro Vallejo wrote:
> xc_domain_getinfo() is slow and prone to races because N hypercalls are
> needed to find information about N domains. xc_domain_getinfolist() finds
> the same information in a single hypercall as long as a big enough buffer
> is provided. Plus, xc_domain_getinfo() is disappearing on a future patch
> so migrate the callers interested in more than 1 domain to the the *list()
> version.
>
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> ---
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
FYI, expected practice is to put your v2 notes in each patch, here in
the commit message. They're more accessible here than in the cover letter.
However, this patch is now fine, so Reviewed-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
|
