[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/7] tools: Create xc_domain_getinfo_single()


  • To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 28 Apr 2023 13:23:23 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFWB7fPYNURP88i6cGvb3OG8iyV8YeJBR9miWlCarbU=; b=OVxUmvvtLVmCmU/4A2p16cPe5RnvK29gh0KGfstItOQBX3IaRfK2vHLswarefXbkVxgLVbV6pop+2S+XN6tCz1uFu2CWqS33xtwv0ItIMlTFFWoZvtEsQAtXhh+FmuMLmoiCRCxzJij9/zKUclQHz4vNthapGnjknMbQx0Z2Wnsi0vwwJh4xxLfl9lzs5842GbiUR1m59K/4rvHrAk4nJ1rfRusq88IkpphrMixPSVeY2pv7UIHxAmfzQitoxc0z6oj0XxDEPBMEFS4FVXJhqLv295aKQQs+wVR2uZTU0MSUOOhgEBSNjvf2CI6Z8B8qITVC3OdVqDsyQRmiRAzf0w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nH+qUEsE+oI+W1qNFdJosl5KV/CLYfMyLnP+eIACX9+G3aFfkBFFdkKIFHsestvXBdlBV5+nSVeu//QwDizj2Cy7RmVYoxnipWH9r677k1lzkBrbuaD+dEKdCsYe1ZJ6n/v+ANocqG3t+kW4s8+heRRJ6i+azZxu2ET6oRE0Nazpt5HC8S++Blm5Vqxxiu5zixJt/+2KpmWyFmtmYyvwH4iByEd2VT5GkLZE5JBeAsMoZA4g7lG2ZAmfFiYdNRBG2lkIgPnj3JsQsQVxuaPZpSwmkJ2o8xmAd1yatofWR5IL9R/DBMzB9xHtjoNw1ZtggNtUeMxCWPnTHdUST87jlg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Fri, 28 Apr 2023 12:23:48 +0000
  • Ironport-data: A9a23:1Cxm3aiKyDFNLP0RBI8wgWFpX161phEKZh0ujC45NGQN5FlHY01je htvXDrUM6yJM2SkKdF2Otm29BtXvcSAydFmGlRq+CE2Fnkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4AWOzyV94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tRDBmgcXg2Zu96S+72ZSM1BqON6cMT0adZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGyb7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXnr6Yz0QLDroAVIBIPVgqdr9mEsHavS4pmF GEep3UHladnoSRHSfG4BXVUukWstxoRWdNWH/c9rh+Ezq7Z4QGxDWwDUzIHY9sj3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTTAAZRsI5Z/kuo5bphDAVNF4C4auk8b4Xzr3x li3QDMWgrwSiYsH0vu99FWe2ja0/MGWEUgy+xndWX+j4kVhfom5aoe06F/dq/FdMIKeSVrHt 38B8ySD0N0z4Vi2vHTlaI0w8HuBvZ5p7BW0bYZTIqQc
  • Ironport-hdrordr: A9a23:xZF+g61SaGs2ggy91qttmgqjBIskLtp133Aq2lEZdPU1SL3gqy nKpp4mPHDP+VMssR0b6LK90ey7MBDhHP1OgLX5X43SODUO0VHAROpfBMnZowEIcBeOkdK1u5 0QFZSWy+edMbG5t6vHCcWDfOrICePozJyV
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28/04/2023 11:41 am, Alejandro Vallejo wrote:
> diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
> index e939d07157..6b11775d4c 100644
> --- a/tools/libs/ctrl/xc_domain.c
> +++ b/tools/libs/ctrl/xc_domain.c
> @@ -345,6 +345,29 @@ int xc_dom_vuart_init(xc_interface *xch,
>      return rc;
>  }
>  
> +int xc_domain_getinfo_single(xc_interface *xch,
> +                             uint32_t domid,
> +                             xc_domaininfo_t *info)
> +{
> +    struct xen_domctl domctl = {
> +        .cmd = XEN_DOMCTL_getdomaininfo,
> +        .domain = domid,
> +    };
> +
> +    if ( do_domctl(xch, &domctl) < 0 )
> +        return -1;
> +
> +    if ( domctl.u.getdomaininfo.domain != domid ) {

One tiny style issue.  This brace should be on the next line.

I'll fix on commit.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.