[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/7] tools: Refactor console/io.c to avoid using xc_domain_getinfo()
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 28 Apr 2023 13:33:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MOB0Ijva4oi5TiSj74GAVfoKZMQqT6eHBNEr/tiIN/U=; b=KMheG4jeNWtePIl44sKM4GdocCzWvDjL/m8dM7OwpUH/c0HHkWYmZip0BO3GX2VVs85PYR1aqcZiv3csFTO6G9FdHeuY+0LEXTSIgpfiFrbMrSqFpKQRsRcTlYo1h/dPg+vtDt0Di7ayEPP90jcLuC89sMazqmuzHVASOngM/FtabwnPN9tlfnhN+TNhamcXf6YFVW4w/4TzRusi3fkTnvjllhxsxTp1rhC5ZXjrTOZodMiypp0ZrYHklA2WXTh2lz6hTHZbhqryzg1coqLFBxx+sBt3iOelp5eJJ8wSY2S5veiiMe3HXEJDxDqJE3I8FDWkQb8WoL8Qx9vMuGyB7A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGFDx/lWdvjNsatouccgaRvVTZGlF2BDE9f8Vsaax396V7A852Fike+BI4IKrF44X/l2/zMxgpLu3XmPAol+LMSpYXS6OtP0EvxOD5eQUeAwbyPJb2G3z9uBtp1DQTlhmM9jRiUZwmgBwywUadXz6Oj2/kUM4/evbDXRv7iIjj5YQQdPzEdBuUX0n+Pl3bm7WWngbLrrv5hNdYwdPD3h8Ft3nD5ZOK7Uoi6cx1QAyg7DyfFSDyoNMlZUEyPMzy9kYwGdhw8qGcmDtB5At24aoIszSb5oipPl6lv5MMxXkv70TkT4555ojZdxRHHNrksK/h+XvE5a+gZUggn6IQumPQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 28 Apr 2023 12:33:58 +0000
- Ironport-data: A9a23:/KJc86g/Mg9albtM4+1EsBbmX161VxEKZh0ujC45NGQN5FlHY01je htvUGDUPveNYDbyfNkkYYyy9R4C78OHm9NrSQVppXszHyob9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4AWOzyV94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQ9F20iYh+crdiamoCrW+g8tJUbfPH0adZ3VnFIlVk1DN4AaLWaGuDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEhluGzYLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXnr6Yx3gLProAVIF4ndUqanvKVtlSddsh+K mkWvSkUjIFnoSRHSfG4BXVUukWstxoRWdNWH/c9rh+Ezq7Z4QGxDWwDUzIHY9sj3OcmSDpv2 lKXktfBAT10rKbTWX+b7q2Trz65JW4SN2BqTTAAZRsI5Z/kuo5bs/7UZtNqEarwhNulHzj1m mmOtHJn2eVVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ==
- Ironport-hdrordr: A9a23:wKQr2Kwac9TNPpCAqKijKrPwPb1zdoMgy1knxilNoH1uH/Bw8v rE9sjzuiWE6wr5J0tQ++xoVJPvfZq+z/JICOsqXYtKNTOO0FdAR7sM0WKN+Vzd8iTFh4tg6Z s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/04/2023 11:41 am, Alejandro Vallejo wrote:
> It has 2 avoidable occurences
>
> * Check whether a domain is valid, which can be done faster with
> xc_domain_getinfo_single()
> * Domain discovery, which can be done much faster with the sysctl
> interface through xc_domain_getinfolist().
It occurs to me that this isn't really right here.
It's true in principle, but switching to requesting all domains at once
is a fix for a race condition.
I'd suggest "which can be done in a race free way through ..." and avoid
saying faster. It's likely not faster now with the 4M bounce, but we
can fix that in due course.
|
