[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/7] tools: Refactor console/io.c to avoid using xc_domain_getinfo()
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 28 Apr 2023 13:43:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p87CTcF+HpANUKE9O88aZaLB9i6E73I4ciXgdDOh8O4=; b=QQgsb5IkjNByUBXTc23ohjqqQdQ9qUShTIYLo7YG9VtpJZ7NRMdDJeGrq0tyWF6kxYspPRHuekvTSmNIwbfTZ9/g3q9vbKaSpE/4Frvp51XLdF5leRSJ7M96Rez/wwU+hl+/k/NEGfNrrewAhAalhagW+07lY43k0a6hTziQHtVHOVEd+/U6fIs/ce8Cugb1rQUt7v4K3mZMjBjDNmeSyFG+rpfHSVUqQ+gmQa58KtRI2VBj5ul+AoivPR1QsM3+we8ARA/xkeML5ZqVBO6C9vCTzqZ1Utm4ghrXxnDp+dWQuFqgAZ+eqW0VGdBdcLEORvdqMvLsngLCs1eMoBdpFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gq2WgbflQ3wloA0pXqSWechOBg/mYwrIgSKmrLCo6EfKgH8q6oTYPVht2DqTvx1UDFU9WfDKtCgcHzw8BFXu293uGePUwsCUH70I+9vCmgoj3URKZFnDiI622nDNZnmUzU8h/E3VOGQmL5dKCW7at/CdG1l+vkKywBbAH2M7ZgVgIBUUOKi1Y3ykKn5WLx1PQbDVRaZ0CncCKxCRfqHY6boqJs6AILLhnAR0yRaIbd/Ykn2YJGulhyd+iFHK/I+1i+sACE6rCqasSJd2HifeCMMXoObUcgmnsivq44xN4NcAmRKKvjHvBAQP/5ydhvQUXQP0UuxIzOQx4qATb2p9Aw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 28 Apr 2023 12:43:40 +0000
- Ironport-data: A9a23:ecO916DMQaZg2RVW/x7iw5YqxClBgxIJ4kV8jS/XYbTApGhz1zcHx mcaX22DO62IYmvwfNEnYdnk8kpU75/dxt82QQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G9C7gRiDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw4e10JH4V8 +4iEW5TUjXarOC34JGiY7w57igjBJGD0II3nFhFlGicJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI9exuvTm7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXzH2lAN9OTNVU8NZ1i1nLmFRUJSERcmSiguvmiwmZd81Qf hl8Fi0G6PJaGFaQZtD5Uh+xpnKeuVgCUt5UHu89wAqJzbfYpQ2eAwAsXjNHLdArqsIybTgrz UOS2cPkAyR1t7+YQm7b8a2bxRutPQAFIGlEYjULJTbp+PHmqYA3yxjJHtBqFffsisWvQG+hh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0=
- Ironport-hdrordr: A9a23:FKXPnKssI11ZsHIT3uKLFg+J7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/04/2023 1:33 pm, Andrew Cooper wrote:
> On 28/04/2023 11:41 am, Alejandro Vallejo wrote:
>> It has 2 avoidable occurences
>>
>> * Check whether a domain is valid, which can be done faster with
>> xc_domain_getinfo_single()
>> * Domain discovery, which can be done much faster with the sysctl
>> interface through xc_domain_getinfolist().
> It occurs to me that this isn't really right here.
>
> It's true in principle, but switching to requesting all domains at once
> is a fix for a race condition.
>
> I'd suggest "which can be done in a race free way through ..." and avoid
> saying faster. It's likely not faster now with the 4M bounce, but we
> can fix that in due course.
Oh, there's also one tabs/spaces indentation hiccup. That can be fixed
on commit too.
~Andrew
|
