[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/bitops: Drop include of cpufeatureset
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 4 May 2023 15:20:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X4lJ5TCVn+ArYoM6a9T+pkoACxd5SnywVsjoTgae4rU=; b=VzK4l8udJDs7dHKzUKpNQH4zv97ZrLhcflGMO2Zu6SF2BfNt+u8lvpbWOCOzPGetk73SvimjgHFaOH8UBOL8eKOIaCyRH8MDSCmAsXTtJMiC/tkVR7UxLjp3czKhjD7AiK7tQbD9ulDey4qpP0buZsGle9niFtLh3pTNooob6bF/BzCCr7qFfp59jPwKnKF71mH9ZCYjA5/V09+pC9NPbYiyiNXo++vHehuCojknBKtikCu+f+6EAfbkgWo1TcN+4okLdH8s/TtPbPkRAGZMvSF0PR2RrJyLQ3nzxtkOPdg+gKJUb05IKOjdpRbtefeE/elWIuc+109JLyri+PwwzQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gm0bs90qeOG0WODSswUzUOhzkZ38lpvH8xbJmewoJqCIMpl/5jqJmehxgFvp3fKoFmehYKbgWrPy87LIpHupktbPM97b3V8Sl7M8ABmQleo9iTSXElA62QOvLSXx5hhkyf0kJ+7d7Xx+EvQ7VdwpkUjWmgj6o4cnADHJgZGLGoGZbxa8akOpWD4tfxFZY1xDdKJZnI+YYJHEF3z4Aq0ThNq8s6RvgQH3kn4an1hcMCksU3Kz9Nib/V6zA5x2M4lCXbU+lkVXO5gp7DMpl7LoG2y1oDzweSDE1eTS3+0BF6gtKzZAHNZEt1Zzu+qSE7tY9LXxGFAXCGMYAfrDwKwqAA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 04 May 2023 13:21:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.05.2023 15:07, Andrew Cooper wrote:
> Nothing in x86/bitops uses anything from x86/cpufeatureset, and it is creating
> problems when trying to untangle other aspects of feature handling.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> ---
> xen/arch/x86/include/asm/bitops.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/x86/include/asm/bitops.h
> b/xen/arch/x86/include/asm/bitops.h
> index 5a71afbc89d5..aa8bd65b4565 100644
> --- a/xen/arch/x86/include/asm/bitops.h
> +++ b/xen/arch/x86/include/asm/bitops.h
> @@ -6,7 +6,6 @@
> */
>
> #include <asm/alternative.h>
> -#include <asm/cpufeatureset.h>
Prior to your 44325775f724 ("x86/cpuid: Untangle the <asm/cpufeature.h>
include hierachy") it was asm/cpufeature.h that was included here,
presumably for the use of X86_FEATURE_BMI1 in __scanbit(). I guess that
wants to be asm/cpufeatures.h now instead?
Jan
|
