[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/bitops: Drop include of cpufeatureset
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 4 May 2023 14:28:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kMmuhkZuM146KCfqk1A9ON90F2AnP2kioSb1kYH7Asw=; b=Gkq+N1ixduwaTugOu8n3yxlKIdcSKvbgEAAaY/Lg3akN5ub7vlxRKhfcMs1vUVwbaMvk3EYjqvW2q/AqCwVmU31Kp9FBznXOj5fkjmlAuwvYfvsOy89SP2WauVYT+p0sGK4f8Q6ELq6U1C2b5o1WF8pI/MKAFerw4F6ha4nBK/Ef5jvk/ZYqGB8ACmX5wDo4AvkDNyqXEWJ/0VUvKJqHOzSTv1XZ2dw3eHklvd9AtI9V+OmlRMiO0JeBJKH5yv2qSv3FXMVhWdoOm5weLbhTRKevRyiwJ0JmmfS/NbfQaJJUJCCYz2IyI8T8/+/NUHHRIYeZ4sfsjoe3eZ2G04xKwA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4d5dFsC43DHD09xJGtFYg87Mx/e+ZnBeEiEzaBU8ljIxpRQOzYMt90lFtDhyIHyAewL7Z2GWMTBSvrbiLn30FHsVE6EEwPyEH+tbbxIwWFkzgGv4b/e2DWi9dW/B709Ry0Q5T0eYgZjdElssundow07gXu3DKS/bgvWO7bS/0Rz4rVm/YqzL0N0s9oU9YJ0sk9ZR+MmlYxNrQ6z4tiRX2/T7DMA9wIq0eSrAUl0ilDUiVyaDrdvVBmzWyrcHcnl7mbhctX1qZMAOxcCM2lJWBCABOz43NxNBsGn4iSaZhdO61OBurDGlhu0U+hEIC5AAzX84LggDFJ5ILXgEQRClQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 04 May 2023 13:28:46 +0000
- Ironport-data: A9a23:IzEegaPgnlvW/h7vrR2HlsFynXyQoLVcMsEvi/4bfWQNrUp3gTYOx jQbDW+AP/nbZGr9f9hyYY7i9EIPvpHRnd9jTQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvPrRC9H5qyo42tF5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0rx4HjhFz fBfE2wUYxym186IxLaLTfY506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzK7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraXwnOrA9tDSdVU8NZnrGOTyUsXByc2UF6gsdiot0emBdJmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaBMQOBWoLZCtBSBRf5dDm+ds3lkiXEowlF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9bABYTzhRqYELukcw==
- Ironport-hdrordr: A9a23:qf7UOqnkZ6gdZOO83J9igm+Jz2XpDfMxiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msjKKdkrNhWotKOzOWxVdATbsSl7cKpgeNJ8SQzJ8/6U 4NSdkaNDS0NykAsS+Y2njHLz9D+rm6GcmT7I+xrkuFDzsaE52Ihz0JdTpzeXcGIDWua6BJcq Z0qvA3xQZJLh8sH7iG7zQ+LqD+T5qhruOVXTc2QzocrCWehzKh77D3VzCewxclSjtKhZsy7G TflAT9x6O799W20AXV2WP/54lf3IKJ8KoOOOW8zuwubhn8gAehY4psH5WEoTAOuemqrHo6jd XWpB8kHsJrr1fcZHu8rxfB0xTplBwu93jh41mFhmaLm721eBsKT+56wa5JeBrQ7EQt+Pl6za Jwxmqc875aFwnJkijR78XBE0gCrDv/nVMS1cooy1BPW4oXb7Fc6aQZ4UNuCZ8FWAb38pouHu VCBNzVoNxWbVSZRXbEuXQH+q3mYl0DWjO9BmQSsM2c1DZb2Fh/0ksj3cQa2kwN8ZosIqM0kN jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnPLtvAQOMl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeWTwZxw9AzXSmnVZ0Wt9ihn3ek6hlTAfsuvDcXaI2pe1/dI4s9vTPEzYs zDe66/WJTYXCzT8YUg5XyLZ3AdEwhZbCQvgKdJZ7u/mLO7FmTUjJ2qTB/yHsuaLd92YBK3Pl IzGB7OGe5n0meHHlfFvTm5YQKZRqW4x+M+LJTn
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/05/2023 2:20 pm, Jan Beulich wrote:
> On 04.05.2023 15:07, Andrew Cooper wrote:
>> Nothing in x86/bitops uses anything from x86/cpufeatureset, and it is
>> creating
>> problems when trying to untangle other aspects of feature handling.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> ---
>> xen/arch/x86/include/asm/bitops.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/xen/arch/x86/include/asm/bitops.h
>> b/xen/arch/x86/include/asm/bitops.h
>> index 5a71afbc89d5..aa8bd65b4565 100644
>> --- a/xen/arch/x86/include/asm/bitops.h
>> +++ b/xen/arch/x86/include/asm/bitops.h
>> @@ -6,7 +6,6 @@
>> */
>>
>> #include <asm/alternative.h>
>> -#include <asm/cpufeatureset.h>
> Prior to your 44325775f724 ("x86/cpuid: Untangle the <asm/cpufeature.h>
> include hierachy") it was asm/cpufeature.h that was included here,
> presumably for the use of X86_FEATURE_BMI1 in __scanbit(). I guess that
> wants to be asm/cpufeatures.h now instead?
Oh. I missed that, but nothing fails to compile, which means that
there's a prior path including cpufeatureset anyway.
I think I'll drop this and leave the header rearranging to a later
point. I ended up having to do the untangling differently anyway.
~Andrew
|
