[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/14 RESEND] xen/x86: Tweak PDC bits when using HWP


  • To: Jason Andryuk <jandryuk@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 8 May 2023 11:53:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AIrHFTZ2UvRvRf56oE/0zxFn6W4wqe81S1kRnPkSL84=; b=nnT6kWS9QYpWtrGRT/9nSZ6O012Va6a2FwqnBC3uki4FIOAX+cbk5ZyA7NTfKWMiFVQs6qeD1YlTNhkEG0bV0Wl+3dkv6Sp0T8cUFj+NgsFBMT6p3TkV9ztUQF/C+SVtjoAzGjBE1j6G9piSylz3l1TgtZmoG4gEqV/T8Vcu+A/RlVUHaqCL0TOWZruUOpz1wXt2F1eQL0rDAXW3+CGPnaOni8SLGnGVj5447I4+p3aIpMuBsvwL3twmPz/PMsMt8tDOWDkno6juWmQSSI7YJQ54PP1Pf/sl6/hI/K7JNuhhxLSwA2N6hq3x3Jz0t/joeeyVEinjjFmYhLXonOy2pw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZmxu9xAj3O930y7bTTSf9fNCpB6pbgCA6bfKxSuHj8SRY2VCwlZSVo7R/HKGII6hzB7Yg2+kCBf70Ji/3TUDbDnIc/xcEjWLUz5XbICY2D0m0whiLx+1sVTFE2UQOHFCe9unMvH1HpcK+9GutZJZ4QLc/MckPI9iNCuO6QJvrgfOIshSasHLOCHOIUThFu9l0P3/PD9X8Br6e5rch4HvCNJaV9TiCdNPFWTKBc95XsYHgOCX6lYc/A4irRMfYO4d1/eJaEgtgfgk1vtCF799lzsFopdHGKncoCy5xZ1CDd4WKWGP0ib8z0g65KiFxGC3mbf/YF06a3lqrfPAoQhuA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 08 May 2023 09:54:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.05.2023 21:30, Jason Andryuk wrote:
> --- a/xen/arch/x86/acpi/cpufreq/hwp.c
> +++ b/xen/arch/x86/acpi/cpufreq/hwp.c
> @@ -13,6 +13,8 @@
>  #include <asm/msr.h>
>  #include <acpi/cpufreq/cpufreq.h>
>  
> +static bool hwp_in_use;

__ro_after_init again, please.

> --- a/xen/include/acpi/pdc_intel.h
> +++ b/xen/include/acpi/pdc_intel.h
> @@ -17,6 +17,7 @@
>  #define ACPI_PDC_C_C1_FFH            (0x0100)
>  #define ACPI_PDC_C_C2C3_FFH          (0x0200)
>  #define ACPI_PDC_SMP_P_HWCOORD               (0x0800)
> +#define ACPI_PDC_CPPC_NTV_INT                (0x1000)

I can probably live with NTV (albeit I'd prefer NATIVE), but INT is too
ambiguous for my taste: Can at least that become INTR, please?

With at least the minimal adjustments
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.