Re: [PATCH v3 06/14 RESEND] xen/x86: Tweak PDC bits when using HWP

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Mon, May 8, 2023 at 5:53 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 01.05.2023 21:30, Jason Andryuk wrote:
> > --- a/xen/arch/x86/acpi/cpufreq/hwp.c
> > +++ b/xen/arch/x86/acpi/cpufreq/hwp.c
> > @@ -13,6 +13,8 @@
> >  #include <asm/msr.h>
> >  #include <acpi/cpufreq/cpufreq.h>
> >
> > +static bool hwp_in_use;
>
> __ro_after_init again, please.

Of course.  (I'd already made the change locally after the earlier ones.)

> > --- a/xen/include/acpi/pdc_intel.h
> > +++ b/xen/include/acpi/pdc_intel.h
> > @@ -17,6 +17,7 @@
> >  #define ACPI_PDC_C_C1_FFH            (0x0100)
> >  #define ACPI_PDC_C_C2C3_FFH          (0x0200)
> >  #define ACPI_PDC_SMP_P_HWCOORD               (0x0800)
> > +#define ACPI_PDC_CPPC_NTV_INT                (0x1000)
>
> I can probably live with NTV (albeit I'd prefer NATIVE), but INT is too
> ambiguous for my taste: Can at least that become INTR, please?

Sounds good.  I'm switching to ACPI_PDC_CPPC_NATIVE_INTR.

> With at least the minimal adjustments
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thank you.

Regards,
Jason