[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/8] iommu/arm: Introduce iommu_add_dt_pci_device API


  • To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 12 May 2023 09:05:41 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pVXLIIKlLw+i1COasw9Ms6RK159MBpPYk5xRi9BswR0=; b=fORDHyXtE4WeANmfcB5Z7+UUNsS4qa18bhjvtLB92VPZYoY6UUcZtSohnjIQKMjpVzW7dlXIOTA3+N+dJQMODz1t31hBlUjZf9g3heOX3ciDo5M7+j21WAn9C0e/tdNT2uq3GNyfSsq1PeAWIRd+n/7lg7bK7HlS4weytshcdLHVk8bwSE9MmQmrJfZc1F+7mAw80g1i5KwWJruxBwbTZ4bKwv32SN2xmVvXcm5nblXmMorLvrMlRavEjYsjLtKd9vvT+fv4fqpOYTfmsqwsL/PWKfH3FB1OijIoSia95XhUrIc3PQxksyQhNconYeteyB4ELOsk4aN9hIuP/uuuPw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GsD5oKNuysPpbjPclJF19xphOgD9CYvnN6DlEGU1GPyudSZyCxOAu0x10b37w72Fb7M5veiQQgaaZQlaW44gAglr8n17yEqSu9wokO6fGJByrYpkJXRD9glZfHxe+3cdx8iLKYZV1pj35122H/YVVHNPpzVtDRiExFW1aO+96wK3ckTWSX/C3W0AieJh/3UR3C1gxEs1bbexAzBMfscb6WuItsO3maJ6jwZy7IIeQcsBRr21hkk/pRqwk6q97rczvqp4w9mk0NU7VrVfLfyDGAC4tpuYSrMUuDzVgJD0hLHaQyqOm4QHMw2VVpHn3gWoYyMygNXl20izgYY+pH7lGQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 12 May 2023 07:06:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11.05.2023 21:16, Stewart Hildebrand wrote:
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -219,7 +219,8 @@ int iommu_dt_domain_init(struct domain *d);
>  int iommu_release_dt_devices(struct domain *d);
>  
>  /*
> - * Helper to add master device to the IOMMU using generic IOMMU DT bindings.
> + * Helpers to add master device to the IOMMU using generic (PCI-)IOMMU
> + * DT bindings.
>   *
>   * Return values:
>   *  0 : device is protected by an IOMMU
> @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d);
>   *      (IOMMU is not enabled/present or device is not connected to it).
>   */
>  int iommu_add_dt_device(struct dt_device_node *np);
> +#ifdef CONFIG_HAS_PCI
> +int iommu_add_dt_pci_device(struct pci_dev *pdev);
> +#endif

Is the #ifdef really necessary?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.