[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/8] iommu/arm: Introduce iommu_add_dt_pci_device API
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Thu, 18 May 2023 17:04:21 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6+AhEIkwA9zB0CpYlpi2x/xWUDwNWP5GuE6V+/Cncw=; b=fP4GXaKg7SComkjdr4dMd6GkArpvAK0LLnhsrEWCPU3ZlfQzl8fKenA/6UUG3SRmXnIXDEulOu4kYtliTP3sfYQHMoiwBw3xLDKfOFukxtgUddfeRmRLFsQpZCYrj4mUFonsKwJuer7JxtsdqbFq1/Bq13bsiazntbb+/+zkiIBvGplaMUVLNif4ZPNnKFhpO2dEywwCcfQ2RNO9aJjPctvkmKxVuOKX5F45h22CEY/b0e/0Jqhdip7zt1wZ5MOppPtp5Nytp4psABx6agDcyuVmH432y866+N0h6ylBMalUgzfXnFOtDsp+LRNMQd17lwPQv3I1CMPdTn0dirpBEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBm/ad1XFmI9e9ONbz2YXpMzcE7pN7/SfxbvinL6RuluYmogJ3DwjbmO/sj9B1HzD/WE9dG7puOrhxJ/F3r32DmbSFapdfF0ZSpwCvPbmu8jFpzvKz6hj2otTkePbPuVebUHzv/QYFeOcpkeSnB0bLBbJKGwGPmkpHZ8XKQH3p99X0oDLTwpIyEBeBk8hg3CkJpf4E+qPE2q0Yw5E5bsV87bbXm0u1v+n1pHV/Z3ii1osXktTAKYj3uh1/44fM2SaMfbwPr1RMew2JdCSIoizApFgKoYCL1+h1Lt9lHH5ay2SmF7oLQMPD7v71msVy5+UBLLvLS+G1vSTnn/z1rUtQ==
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 May 2023 21:04:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/12/23 03:05, Jan Beulich wrote:
> On 11.05.2023 21:16, Stewart Hildebrand wrote:
>> --- a/xen/include/xen/iommu.h
>> +++ b/xen/include/xen/iommu.h
>> @@ -219,7 +219,8 @@ int iommu_dt_domain_init(struct domain *d);
>> int iommu_release_dt_devices(struct domain *d);
>>
>> /*
>> - * Helper to add master device to the IOMMU using generic IOMMU DT bindings.
>> + * Helpers to add master device to the IOMMU using generic (PCI-)IOMMU
>> + * DT bindings.
>> *
>> * Return values:
>> * 0 : device is protected by an IOMMU
>> @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d);
>> * (IOMMU is not enabled/present or device is not connected to it).
>> */
>> int iommu_add_dt_device(struct dt_device_node *np);
>> +#ifdef CONFIG_HAS_PCI
>> +int iommu_add_dt_pci_device(struct pci_dev *pdev);
>> +#endif
>
> Is the #ifdef really necessary?
No, I will remove in v3
|
