[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 04/15] build: hide policy.bin commands
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 24 May 2023 09:11:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d3iEGQwJ6NHRvRWoDuRx/P3UeRJpn+HOmoBB6dyYtQg=; b=TtWepDnCW5MIYpIYkIrboQViPc6QPcCIG7umVEhhC69UhKXQ+F6JRn7s/Sg3yNRIsfOoCvaz0Fe2KBZfNX1MaGGv/ztajH2x4c9PthM6zD6+7wKz+baPK4gIA8jeEvo1Ge+dKKuz13UdXmBNn1TbqWiT93OKXZjKM2onET+9uRkhpyssLWuuUXEIh6t2uhcWbpWRehZdY4knvV/ZPpG00++LY69Tn3uysMU7N80qsSPrjBwnShELyLbRVeXXmUBYkWWOugYAg9270Mr8rms9fYbDPbkwpqlFdoBcYyIyb1A+GvtqmGF0xxnD2si7OvXFIOqhIjbAU/kn0gmh4hR1MA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fpX8awG+JPCMcscF2udFAkS1ysSp0zzb9OhFoYk0fxeXyh1ABrF9ubbjwxJ/JdaYJ8y1Bj2JhWk+DAcaDH9jC1L8lPc6+gEGwjWSL1ZgGaiMUIVyhgjjW2nbAV3F7xSBdkhK2C2Fr6MdmRCJfpwYCM6pta4eFNz6hZXRE9w+I0fefjdVSMehpeTSOKc0Wa9v37U/mCU/8GaQqIfsif9NZ9bMBa8NEbn3Q0fBlzuFDDHdiY3IvDCYyY+1DrvBycD9Eh+q8nZ2ozvGlVAI69hfI4kNiuziivNWC26orcvN33QS6bsAFklHh/JBBhFIxaOLn1qTcSFW+h6V49mfPzVT7g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 24 May 2023 07:11:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.05.2023 18:38, Anthony PERARD wrote:
> --- a/xen/xsm/flask/Makefile
> +++ b/xen/xsm/flask/Makefile
> @@ -48,10 +48,15 @@ targets += flask-policy.S
> FLASK_BUILD_DIR := $(abs_objtree)/$(obj)
> POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION)
>
> +policy_chk = \
> + $(Q)if ! cmp -s $(POLICY_SRC) $@; then \
> + $(kecho) ' UPD $@'; \
> + cp $(POLICY_SRC) $@; \
Wouldn't this better use move-if-changed? Which, if "UPD ..." output is
desired, would then need overriding from what Config.mk supplies?
In any event, much like move-if-changed itself - please avoid underscores
in names when dashes are fine to use.
> + fi
> $(obj)/policy.bin: FORCE
Nit: Blank line above here please.
Jan
> - $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common \
> + $(Q)$(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common \
> -C $(XEN_ROOT)/tools/flask/policy \
> FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) POLICY_FILENAME=$(POLICY_SRC)
> - cmp -s $(POLICY_SRC) $@ || cp $(POLICY_SRC) $@
> + $(call policy_chk)
>
> clean-files := policy.* $(POLICY_SRC)
|
