[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 04/15] build: hide policy.bin commands
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 25 May 2023 14:34:06 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 25 May 2023 13:34:22 +0000
- Ironport-data: A9a23:2lSInaJ8fZH7LswiFE+R55UlxSXFcZb7ZxGr2PjKsXjdYENS1DdUy TFLWGCEM/rfYmKgeIxxa97l90kDvJ7SydRnHQVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrbwP9TlK6q4mhA4wZjPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5TGVAX6 OwzdwkRf0+HhL7qxJ+2RNhF05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHJ0Fxh3F+ D2uE2LRACxAbta44iq+onu329/mvynqZaAgPejtnhJtqALKnTFCYPEMbnO5q/Skjk+1W/pEN lcZvCEpqMAa+FSwS9jhXzWxuHOeogMHQN1UDvE77weWjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+dtT6oMDIZBXMDbyQDCwAC5rHeTJob10yVCIw5Sejs04OzQGurq 9yXkMQgr5ELvJcWx47kxEzW3Dav+sTNYwM71yyCCwpJ8ThFTIKiYoWp733S4vBBMJuVQzG9g ZQUpySNxLtQVM/QzURhVM1IRej0vKjdbFUwlHY1R/EcGyKRF2lPlGy6yBV3Pw9XP8kNYlcFi 2eD6FoKtPe/0JZHBJKbgr5d6exwlcAM9vy/DJg4i+aihbAvHDJrBAk0OSatM5nFySDAa50XN 5aBatqLBn0HE6lhxzfeb75DgeN6m3tknjmKGMiTI/GbPV22PST9dFv4GAHWMrBRAF2s+205D Oqzx+PVkk4CAYUSkwHc8JIJLEBiEEXX8ave8pQNHsbae1oOJY3UI6OJqV/XU9A/zvs9eyah1 i3VZ3K0P3Kk2yOceFvUMCw4AF4tNL4mxU8G0eUXFQ7A8xAejUyHtc/zq7NfkWEbydFe
- Ironport-hdrordr: A9a23:VQj646G2YsorJ6EkpLqEwMeALOsnbusQ8zAX/mt6Q3VuA7elfg 6V7Y0mPH7P+U4ssRQb8+xoV5PwJE80maQFg7X5eI3SPzUO21HIEGgB1/qH/9SIIUSXndK1l5 0BT0EUMqyWMbEVt7ed3OB6KbodKRu8nZxASd2w856ld29XV50=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, May 24, 2023 at 09:11:10AM +0200, Jan Beulich wrote:
> On 23.05.2023 18:38, Anthony PERARD wrote:
> > --- a/xen/xsm/flask/Makefile
> > +++ b/xen/xsm/flask/Makefile
> > @@ -48,10 +48,15 @@ targets += flask-policy.S
> > FLASK_BUILD_DIR := $(abs_objtree)/$(obj)
> > POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION)
> >
> > +policy_chk = \
> > + $(Q)if ! cmp -s $(POLICY_SRC) $@; then \
> > + $(kecho) ' UPD $@'; \
> > + cp $(POLICY_SRC) $@; \
>
> Wouldn't this better use move-if-changed? Which, if "UPD ..." output is
> desired, would then need overriding from what Config.mk supplies?
I don't like move-if-changed, because it remove the original target. On
incremental build, make will keep building the original target even
when not needed. So we keep seeing the `checkpolicy` command line when
there's otherwise nothing to do.
I could introduce a new generic macro instead, copy-if-changed, which
will do compare and copy (like policy_chk is doing here).
Thanks,
--
Anthony PERARD
|
