[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 00/15] build: cleanup build log, avoid user's CFLAGS, avoid too many include of Config.mk
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 24 May 2023 10:27:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mZJTJiNe2yrvWtjAcW+mCPp+FDrPb5c4YG/4tfh/ItM=; b=fQzAPBgJb5aAGRZ7/N364/Xk2ELrtq2OwSHaPtOyeLjWM+xupkhmTsXVGGSWKXM+1xivHvFRtQr/M6yNOQpk5H+zyZbqeApihWWDNvHB7+6QJNMaYuiu/IcEFZPUp1JECWvV8Z4dnPK0Sac/C5MjPcqN0aEo+KhVpMoKIWCjutNeytSP4pcA4Ie4J1bxVyd07dF+RuHUszHDwqXcoWP7Rox+sNt08zvj1ZRGOS4ERw/LwUwUXCEOo3x7kq+VwUQUNyj7mfkCuY5NAhT/ElZasmvLapwWqWUc0RkPDsn39ZDjKCQS6DVTXqMD5PTmWnN+QNLm9SHqfUJ7Id6FtnS8Ww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nmZcyKOCfnMD1OYEkCR2kHTNgKt0iPwnBM2wMTQ5+NgvUzuAEwhDZEljKTpmJGK35FY6jHxfzLD224+P2mqz9b2WbNRgEVvM4+MzAA6/+v5WKRxhn85WKNXZqwP1bYoZFTXX9HXL1TWcqawjqGMaKreNn2LBmGFW2lOEpE4oyKn9+YDV2KWcbECpk8SYTDw+gy6NL53iFkZLSKzIuVY+HQzzaFmd1M5jJmdegILZ5yQLR7cEsNlHTjsHJe3JHVmluJnj/eSyB1zxeYAI1DCkpKRy4IsCGYZnYBfHuh02ykH2dCFwMi2jUiNY9IJYPefVNEVuHTo44qy17LV8rO9AGg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Wed, 24 May 2023 09:28:12 +0000
- Ironport-data: A9a23:hJ3P262OwjEVxBaXe/bD5c5xkn2cJEfYwER7XKvMYLTBsI5bp2QOx mFLXjuDaPqOMDeget5+b4W1p0MD7Z7XyN9kG1Q6pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gFkOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfDE5N1 eQmDmsxbT++3ee865u6b/VwiZF2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PlGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHurCd9MSu3hnhJsqH+omHU2LRwEbErljveCmhWnWPQCN 1NBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQqrNQzRCAq/ laRksn1GCd0t7mIVXOa8KzSpjS3UQAWKmkYbCNCUgoB4PHkuog4ih+JRdFmeIa8itzuBTjx2 XaEtiE4jLQIpdEH3OOw+lWvqzCxopnESCYl6wORWXiqhitif5KsbYGs7Vnd7N5DIZyfQ13Hu 2IL8+CB6MgeAJfLkzaCKM0GFaul4PutOzTGjVliWZIm8lyF8Xmpd5Fd+zF6KUJgNO4LfDboZ AnYvgY5zJRUOn2tb6N+fYOqI8svxKnkU9/iU5j8ZNdUfoJ4cgPB+Sh0fFORxEjkik1qmqY6U b+ldsKrAWcfGL5Q5jO8TOcA0pcm3ik7g2jUQPjTzR6qzL6fb369UqoePR2FaeVR0U+fiADc8 tIaMtTQzRxaCbf6enOPrdZVKk0WJ38mA5yws9ZQauOIPgthHicmFuPVxrQiPYdimsy5i9v1w 510YWcAoHKXuJENAV/ihqxLAF83YatCkA==
- Ironport-hdrordr: A9a23:GjEKJaEpYT7DllHLpLqE18eALOsnbusQ8zAXPo5KOGVom62j5r iTdZEgvyMc5wxhPU3I9erwWpVoBEmslqKdgrNxAV7BZniDhILAFugLhrcKgQeBJ8SUzJ876U 4PSdkZNDQyNzRHZATBjTVQ3+xO/DBPys6Vuds=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/05/2023 5:37 pm, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
> br.build-system-xen-removing-config.mk-v1
>
> Hi,
>
> This series of patch cleanup the remaining rules still displaying their
> command
> line.
>
> Then, some change are made in Config.mk to remove build-id stuff only used by
> Xen build.
>
> Then, the variable AFLAGS and CFLAGS are been renamed XEN_AFLAGS and
> XEN_CFLAGS
> from the beginning to about inclusion of users CFLAGS as those are usually
> made
> for user space program, not kernel, especially in build environment for distro
> packages.
>
> Last patch removes the inclusion of Config.mk from xen/Rules.mk, as this slow
> down the build unnecessarily. xen/Makefile should do everything necessary to
> setup the build of the hypervisor, and is its only entry point.
Thankyou for doing this. I'm tempted to summarily ack it, but lets do
things properly.
One thing though, which I think might be a regression but I'm not sure.
When doing an incremental build (second build with no change), we get:
...
UPD include/xen/compile.h
__ __ _ _ _ ___ _ _ _
\ \/ /___ _ __ | || | / |( _ ) _ _ _ __ ___| |_ __ _| |__ | | ___
\ // _ \ '_ \ | || |_ | |/ _ \ __| | | | '_ \/ __| __/ _` | '_ \| |/ _ \
/ \ __/ | | | |__ _|| | (_) |__| |_| | | | \__ \ || (_| | |_) | | __/
/_/\_\___|_| |_| |_|(_)_|\___/ \__,_|_| |_|___/\__\__,_|_.__/|_|\___|
make[2]: Nothing to be done for 'all'.
make[4]: Nothing to be done for 'all'.
CC common/version.o
CC arch/x86/efi/boot.o
...
Where I think those two "nothing to be done for 'all'" are new. I don't
see them in a build from clean.
~Andrew
P.S. I do have some other notes for further cleanup, but I'm not going
to extend this current series with them.
|
