[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 03/15] build, x86: clean build log for boot/ targets
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 24 May 2023 10:31:13 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vsWwIvUADpcI8Ht5ETuwIlS1fasThyPx7k8697c00R8=; b=A8wBnz+aBr2rSAIPytjVgg0B9KyFApJTCFn/rtt8R6UEvSIrotc9c8e6sD38raunfTJPpSwCIIrsrmV+Wb6UEncLSwvc6Awbic854oYN5F5vedPeAyW+ZnngmMlddZPcjZhrmKiqmMaDEo/OPlVDQzF7LfwEGXBnxemCyqyJn1PUn2BgCzmhRVgLqlvO8ld+QVANHNkL/b+hLD8KkJZiU4u0KDt1ZHNfG2lgLxJ3wwIpgj6Ui7DX+IrQS+913e1wgspqPX8DenawsCpZCR/G78DLbwOPv7iaPrwojsqA2Kei0kFsofKdal7yknZaq2sESsB/lOPVvbzTV/YiUlt1aw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6l1Vat6Z8oUyi4uFioKhO7h+BxXLIQTAaCxCNTD+7ylae2OOn3NmIxfl1otlJUJYpvXdS2KoYGRsbDIiZii7/8m1nAa4OQeF1aBXGSYbCw9XciaV14f1rF7YAOt7TZa0ZGc4G58Vn4oZgP7kmdqCpcEetqyyysZqDddpsI58L3+Xy0kswKax/YfdRnqzYOn8p1bgf3M6g4ldbLpJvsWLpmfAFeZSNcs/3dKQ90Cj8ldiZ9XL/iDq82ueuCjieyACDPlCNsELLO19rn0QMjvWdZ4dVHZw70zLg4KiFH/pBo7HuviTRim7NGCllgRQIC/8uWg3GVh1jojDIhuycDF1w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 24 May 2023 09:31:33 +0000
- Ironport-data: A9a23:xaBAyK15MwBau8GBQvbD5f5wkn2cJEfYwER7XKvMYLTBsI5bp2QPn GEbDG6POv2IYmbxLo90O9y28UhTu5KGzdQ2GVNkpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gFkOagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfO08T+ s4Ib2A3XFOR3/nr6uqASeVpr5F2RCXrFNt3VnBI6xj8VKxjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsi6Kk1AZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqiAN9DROzjqZaGhnXCw1BJLDg7R2K8uP68pUi3R+tUJ Usbr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOtsU7WDgr3 V+hhM7yCHpkt7j9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A79y9pog210jLVow6T/LzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGzASpoRGpBcmS8g Q==
- Ironport-hdrordr: A9a23:B1wpQajHhVovICtopNC8zpfC1HBQX8d23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewKkyXcH2/h3AV7EZniahILIFvAZ0WKG+VHd8kLFh41gPM tbAs1D4ZjLfCNHZKXBkXeF+rQboOVvmZrA7Ym+854ud3ATV0gJ1XYHNu/xKDwTeOApP+teKH PR3Lskm9L2Ek5nEvhTS0N1F9Qq4Lbw5eDbSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK7aY+/X PDmwnZ4Lzml/2g0BfT20La8pwTwbLau5d+Lf3JrvJQBiTniw6uaogkc7qevAotqOXqxEc2nM LKqxIAOd02z3/KZGm6rTbkxgGl+jcz7H3Jz0OenBLY0IHEbQN/L/AEqZNScxPf5UZllNZg0J hT12bck5ZMFxvPkAn0+tCNDnhR5wCJiEtntdRWo21UUIMYZrMUhYsD/HlNGJNFOC7h8ogoHM RnEcmZzvdLdlGxaWzfowBUsZeRd0V2Oi3DblkJu8ST3TQTtHdlz3EAzMhapXsE/IJVcegy28 30doBT0J1eRM4faqxwQM0bR9GsN2DLSRXQdEqPPFXODsg8SjLwgq+yxI9wyPCheZQOwpd3so /GSklkuWk7fF+rIdGS3adM7gvGTAyGLHXQI/llltpEU4DHNf/W2XXpciFrryLgmYRQPiTjYY fxBHoMaMWTalcHGu5yrnnDstdpWD8jufYuy6UGsmK107P2w7LRx5zmmdboVczQ+GUfKyrCK0 pGegTPD+N9yW3uckPEoXHqKgbQkwrEjN1NLJQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/05/2023 5:37 pm, Anthony PERARD wrote:
> diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
> index 03d8ce3a9e..2693b938bd 100644
> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -26,10 +28,16 @@ $(head-bin-objs): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic
> LDFLAGS_DIRECT-$(call ld-option,--warn-rwx-segments) :=
> --no-warn-rwx-segments
> LDFLAGS_DIRECT += $(LDFLAGS_DIRECT-y)
>
> -%.bin: %.lnk
> - $(OBJCOPY) -j .text -O binary $< $@
> +%.bin: OBJCOPYFLAGS := -j .text -O binary
> +%.bin: %.lnk FORCE
> + $(call if_changed,objcopy)
>
> -%.lnk: %.o $(src)/build32.lds
> - $(LD) $(subst x86_64,i386,$(LDFLAGS_DIRECT)) -N -T $(filter %.lds,$^)
> -o $@ $<
> +quiet_cmd_ld_lnk_o = LD $@
I'd suggest that this be LD32 because it is different to most other LD's
in the log.
However, this is a definite improvement.
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Tested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Happy to fix up on commit.
|
