[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 12/15] build: avoid Config.mk's CFLAGS
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 24 May 2023 09:34:23 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WRFR/mOq552L5wgb1XLOo2zPC3fxeM/Ns4sXOcT08VM=; b=KYlFxgEfyZvsFk1aCdIrL12LUlrJPKJhT+J1gfA1yicdfToGVRnWET673v0C5zzMOXActlAnco7rWqE21+QvAJ3GAtr7j/BXu9iHJf0GfCVp7R5v9MBxQ/n+Qw5MPDzod1nHfLpuIH57KatwpUZyrHDIlOmzphOuMxonM+Lgx+wpMFIP0Nz1IjLcTYHIxLpAtfWmG+O6P0gbMtGi9oSk7ypMnOZxyYy5UdAViZYOQ44//zQcP09SsElxc2YJU04TKaesmQsqGbCbdsVcC6i0JX6TbeyOi/kSrmOFqy23sMocDkjyMFzVzfVZPp3ba5SRISHAdguoAnl51l+OhYcvQg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gwHOFCOwuxmOagW2vH0jRfYjqY1hFeLMWchi06dTuk13RYuOG0nbwavgtDAkbEHl9S97PsQNivqWX0cWrhUkobc2ki9wJXdpb9wStvh0YeKld72EQ0GMe39agpfwjYqETl411VrYti+mDjuhj9FXHq9sUfdpzdvnR1JYi1BzC/kVCyd04i4+QqT0TINknbIsb11vgaAko071G4FoKxEUyDV+X9dQU629MQwM0ICUtXBgyR98Kc5Cr8IxXmsfVDUkLUEfy/i8G8pXwCSVU7KzFb2bkI2tWzScGShnoT7jW9BcJ4x+ImZAm9xd3cucV90NBw+0cgSUL7m8nxi3VcPoBw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 24 May 2023 09:35:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZjZZXWyxFq0oXWE+6zQEJ2UT2c69pKp4A
- Thread-topic: [XEN PATCH 12/15] build: avoid Config.mk's CFLAGS
> On 23 May 2023, at 17:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> The variable $(CFLAGS) is too often set in the environment,
> especially when building a package for a distribution. Often, those
> CFLAGS are intended to be use to build user spaces binaries, not a
NIT: s/use/used/
But I’m not a native speaker so I might be wrong on this
> kernel. This mean packager needs to takes extra steps to build Xen by
> overriding the CFLAGS provided by the package build environment.
>
> With this patch, we avoid using the variable $(CFLAGS). Also, the
> hypervisor's build system have complete control over which CFLAGS are
> used.
>
> No change intended to XEN_CFLAGS used, beside some flags which may be
> in a different order on the command line.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>
> Notes:
> There's still $(EXTRA_CFLAGS_XEN_CORE) which allows to add more CFLAGS
> if someone building Xen needs to add more CFLAGS to the hypervisor
> build.
>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
