[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 13/15] build: fix compile.h compiler version command line
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 24 May 2023 09:43:42 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UMAP0MJrxj6d0XOTtOQ8XfnC7l/aGKJtyutcJWc2aPY=; b=kkLbpe+OceNiDq+j/IFnEydCFQA9xkbtu4BcXO5/Z9zCN1+9JuAPNACZl5U1WfpgjOzWoW0H9TW87NIOfG1dQdn9vWK8X5Y9AHi0xyhpNMxJ+C7FZmojKYK8IJ+GHeZHYZnAmrpzSqqBtWs8HhL8Wb+IQxLAyclC4CU5FN0BMP8y+uYFREGkPrGUEXjJnWR0MOULGeOtnArOIEKwf0Aa61DIU+glFipWzvRyp1MQCl4KrabwlZ9P08hl3HxhbvUEnrgoFU3slPMv7DQY1rjCxv213xiMWQeNOMa9HSOOURUDAAqOGgyy8T9TSoz/ktBEyvT9OyVATTQQhvxa53D5JQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLAkvsOad2KTObRXiny8oXaX5jKRHX3b548j4d35RkrzZl3pQyIyhu7iCqPdkJgG+HLj3f/tuj6JzeC5s9jDCjVwFuAAhVYDxHs+PS3Cljge5ZeA+Rp/ZeuBw6B48mI60iTqEOC5tz25LuLt9fNeDXWcu8UbX5xCxuGSFPvltM7f/iT+X01N/86PmOyzvBbSTVd4v2c2pnvtnmQPmVii/gaTDr4PJ5W0IZwEh0VBCqyFm1Rpl/N3dEX7h5BWuZhZVV2Xfg/6NsXj0nfDcd2STd+8dVQJSkCzGv1Rfr9p4hjPHQqiXAR6RjcePzCIAJJ4VDKDAxljuKw0QAEOJDkeaA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 24 May 2023 09:44:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZjZUfS+Hth9ncdEKi1WC1jlJ0EK9pLTuA
- Thread-topic: [XEN PATCH 13/15] build: fix compile.h compiler version command line
> On 23 May 2023, at 17:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> CFLAGS is just from Config.mk, instead use the flags used to build
> Xen.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>
> Notes:
> I don't know if CFLAGS is even useful there, just --version without the
> flags might produce the same result.
>
> xen/build.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/build.mk b/xen/build.mk
> index e2a78aa806..d468bb6e26 100644
> --- a/xen/build.mk
> +++ b/xen/build.mk
> @@ -23,7 +23,7 @@ define cmd_compile.h
> -e 's/@@whoami@@/$(XEN_WHOAMI)/g' \
> -e 's/@@domain@@/$(XEN_DOMAIN)/g' \
> -e 's/@@hostname@@/$(XEN_BUILD_HOST)/g' \
> - -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) --version 2>&1 | head -1)!g' \
> + -e 's!@@compiler@@!$(shell $(CC) $(XEN_CFLAGS) --version 2>&1 | head
> -1)!g' \
> -e 's/@@version@@/$(XEN_VERSION)/g' \
> -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \
> -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \
> --
> Anthony PERARD
>
>
Yes I think Andrew is right, so I guess $(XEN_CFLAGS) can be dropped?
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
I’ve tested this patch with and without the $(XEN_CFLAGS), so if you drop it
you can
retain my r-by if you want.
|
