[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 13/15] build: fix compile.h compiler version command line
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 May 2023 14:48:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l0vGmsTjxn+2fgr6wE3651FgBj6ujZMA+pLxHCcRnUo=; b=b8rplEC1HTyAc0y3oFPK80kCQcNJlHWRHuJ03yVQAB2w1BThlRyK8iHgPqTER2MjqN7JN+wvmr5ahfr2644NbLnguu41mqbpSMjT3Y6H/zGCCWLbsCapPOXoesynVCqEHA+EaxglUW4YDvuAQUuftvjimIkGjbAbCOk/slXxixINEPmTpZ84cPXlEzPxz2bpi91i0ifcTy5YMTIzN2sj4GbuHHU895sZJut3cJZgb2/Z2ZnDpGI3S214F8GPzjKeu1VWl4nSIzczB8iblvX1cGWHU70JjpZ5T/Ig9LAtLReNJDdTzAp+P7h1E0mX4AkI9h5L+nqIQA399T2Pd0xG8w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oaWTopFuOrzF8y7FA2XjuWV5BlzOC0P9fbohT6b6//I2bmYLuVtZ8hJ/sx7MWbxhOYBVlAhEKTh7ksw8Yq2yk8wurtDgCLSEI9SVm4AjU6+6G5sCgWataJ4NHeA/Zng2U3pJIo3mv56KGbxqKcCyvkM8eySZcINjYd3qc3H+HKgHLof106A9yB2sb66NshqGWvhvNllB/CohVhDwETwF+3DdmCLkaMi1tlAiKNMi5E3GSQdZCqRnTQwxYtgMOwccJlwyi6OqYcTRCu0RfEeBybg4Fq4glCHXItkk3MZsPSnaakHN2Ev46nrbqmuQyoGtys6gAYZbwD23/xarkJZc4w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 25 May 2023 12:49:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.05.2023 20:14, Andrew Cooper wrote:
> On 23/05/2023 5:38 pm, Anthony PERARD wrote:
>> CFLAGS is just from Config.mk, instead use the flags used to build
>> Xen.
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> ---
>>
>> Notes:
>> I don't know if CFLAGS is even useful there, just --version without the
>> flags might produce the same result.
>
> I can't think of any legitimate reason for CFLAGS to be here.
>
> Any compiler which does differ its output based on CLFAGS is probably
> one we don't want to be using...
Well, I wouldn't go quite as far in general, but I agree for the --version
case. Actually at least with gcc it's even "better": I've tried a couple
of 32-bit compilers with "-m64 --version", which would normally choke on
the -m64. But that options is ignored altogether when --version is there.
(Which has up- and downsides of course; the command failing might also be
useful, in telling us that the compiler isn't usable in the first place.)
Jan
|
