[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PVH Dom0 related UART failure
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 24 May 2023 13:52:12 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+rJonwk2U3lw/fR6Ok41tkijMS7ayKAfe4A66fj6cLI=; b=YBlK4L31kvDnrzIp7OSCdX8LrwC08kVyijdHOmqTRxfdPQS34aGmd52u3Gy6KuS+QzEXSutZwimlrQ8fXFeH+OzvejlWkjtpIOB6jIolgX1arvw8L8MmIphvoB7yhfFmZvGcj1dTxqJ9XEWYhIMsh0CRSv8iOP57CMrMow4nPpYvHzDElH7ur8Frk2J1dqFl/Cr8SzgatOgIAIQXMWBD/m1Jo/XOay7p104UVVrk/WN/yWGT7dprvyiiArsmyDeWYKV8OrvaXTU9gPkS9p6DS42UOv/sNl3UHlH5r7ck8eA6yluIChkQMSxE0rZKqpW7HE4+ODiz15m9GgfvUlaL3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I7CEQb4gtLqMfyzNokMedmBu7AxoOZ2gjmLWpYVfkyo0jjeZBi14CKC5i6d+l2EnMENp7sL/a4DJ9ZJnqOA1Xu7SPO3Ok+veOsmN+AAVxp1UiMj/4ibk87AUEU4YFyyJ8Wd0zX2/ch/oK/4CUlYdBPGT8q1oYAmd5DhDob72/q9rjqbBqouHGaO/y/arB7YYkRE/Lw75pyVJtbMW8Xh4t1BtF/+mK8anbS+u9zBiGgobGstgvABmMsq4oW5TfU7YvPb/tFFu09+P0YpmbJyX/FsikuLkpDmX2m0vl/WPWMxZbLIEb/EvwbKH0TJEmWk8Pu9xsTiUwyaJyaU7JAwrRg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: andrew.cooper3@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, marmarek@xxxxxxxxxxxxxxxxxxxxxx, xenia.ragiadakou@xxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 24 May 2023 11:52:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.05.2023 08:14, Jan Beulich wrote:
> On 24.05.2023 03:13, Stefano Stabellini wrote:
>> For sure I can test your patch. BTW it is also really easy for you to do
>> it your simply by pushing a branch to a repo on gitlab-ci and watch for
>> the results. If you are interested let me know I can give you a
>> tutorial, you just need to create a repo, and register the gitlab runner
>> and voila'.
>>
>> This is the outcome:
>>
>> https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/876808194
>>
>>
>> (XEN) PCI add device 0000:00:00.0
>> (XEN) PCI add device 0000:00:00.2
>> (XEN) PCI add device 0000:00:01.0
>> (XEN) PCI add device 0000:00:02.0
>> (XEN) Assertion 'd == dom_xen && system_state < SYS_STATE_active' failed at
>> drivers/vpci/header.c:313
>
> So this is an assertion my patch adds. The right side of the && may be too
> strict, but it's been too long to recall why exactly I thought the case
> should occur only before Dom0 starts. You may want to retry with that 2nd
> half of the condition dropped.
And indeed it needs dropping. The patch pre-dates 163db6a72b66 ("x86/PVH:
permit more physdevop-s to be used by Dom0"), and despite me being the
author of that one I failed to make the connection. Which quite clearly
indicates some other oddity, because in principle I should be hitting
that same assertion then as well when booting PVH Dom0. Yet I don't, so
I have more to figure out.
Jan
|
