[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0
- To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 May 2023 11:31:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6KY2ydO/NQVS4BYUFFczmONTLzCJLHomyYln0F7WV8c=; b=aStlLGmXYJO1Xw2vfPV6pZFX2vNkYyAZB4YL2Eu5Bxw7Emp7IdmtLdZw1X0Ljjdpro+yo1GnmfH343j3inPaoIrr4zQmxvdmBfnTRJZzZljptwaf2AxcDljlJHB4EErYuSGgGnkUre1mHy+kCq/OssH86ziRkdsd14rSNd0I+BvI+r5K4LYBk9JtdJreNK6hT883H1DRFHG9xlbR5Ue6dwxStP7gGY892EPKebTXVrm3d/iSUZ2psjiCFidaDGSJums3T0L1StllZSi4ZJQQJQi8k75kEuslryltbtsZduWm2w4V8muUROF98B4O9ye5iIPHqV+jottS39h3qXMPTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ia345a1+gL+X9cnlb+2pcNPA9HfCDKqOXywG6Bk9BKAxGBRhCTDkn/GKbx7HhO5BkMrEac1JS9GvIfHn1wwPE+UXIbCxsija5vzPJ0O1D5Mq4EKkUTzvHEjhvf2uZ4kN3wtsPwnj10swDT44hqsML+hcvLVpIkqbG2Ory1imCB3RLtxBrGHmpVjA9WJo9xIXQLYN14mfElEzAi6dQqkuyOXS0Jg0UNDf1Mkt7ZR+BHzRrvSbwaFKin3jundPuhPujriCEwsWUHa56v44DplI6WC10ajE9/LL00XJbWm0VyGfDTrvcC6PGlUWEA5SUyWy5CPoopVe6L2/AXBmNAmi4Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Peter Jones <pjones@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 25 May 2023 09:31:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.05.2023 18:05, Ross Lagerwall wrote:
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -772,8 +772,14 @@ char * __init xen_memory_setup(void)
> * UNUSABLE regions in domUs are not handled and will need
> * a patch in the future.
> */
I think this comment now wants to move ...
> - if (xen_initial_domain())
> + if (xen_initial_domain()) {
... here. And then likely you want a blank line ...
> xen_ignore_unusable();
... here.
> + /* Reserve 0.5 MiB to 1 MiB region so iBFT can be found */
> + xen_e820_table.entries[xen_e820_table.nr_entries].addr =
> 0x80000;
> + xen_e820_table.entries[xen_e820_table.nr_entries].size =
> 0x80000;
> + xen_e820_table.entries[xen_e820_table.nr_entries].type =
> E820_TYPE_RESERVED;
> + xen_e820_table.nr_entries++;
Surely this can be omitted when !CONFIG_ISCSI_IBFT_FIND?
Jan
|
