[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Tue, 30 May 2023 14:55:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ti+fh3IQP2kqX6vJ8EdZ90JnboJj2ATrgwrAFuSDeg=; b=QXMFw4/g8AhhmZG0GIfuUeABlWOuO1OyYqGoWMkGEcwMN/fK2jlEmsOKL8excw59KHDB3ZvKWXZLntRjLaxZcxbg99rQqjXeFYqIlvz7IAK01+uITHyx1BLZ/YvO0NMGEzLre/y2MrmcFSnJgPAQkzuXQ7SvTmiVfMcCIrP8p+ior0O5AhFCc+LDpXNIeM0gxrzRn0TBtOirVZp1zshn+MCyddeJyRiifUaXVrQap10JwJVhvVDhra2V03gPQSORRZ7XX6nRoQzgn3fH3B8eRPrbeTTkWJfDDWXYUCBMfPlsXLeZMVn1/rOqrtt8k78jU6kShx69p31+C3O27BOmHQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ock+eokmm1M8B6IPSnLDsHWlI8DAxADJUHuJspJKlqtFFsJ6O3mtgBCGHMObX7Y0YTbEe5+J7M/jl8kyIao3c8kKkPf1xkzEF3zPHBXL1jbbmMvEFw+jkX2GCvXsacy1pApgUe8g0h2WLBIEB7vtXwF65GXr7wM3W9E+x+E7/srzqE51P9Vss8fM324R1Rq9/bBJKJm65ydAXiH+2HgwX8ej71TJiTFhtmBXn6p7Rc57S+bFGFJvG1o8yLs3hubXbOHM/3Xx/Isfmk/mLOj0FMn7yXFrFyh6YlO4G1HFl83e7z0iFqk8KisAd7fIqAmpPM8seQNrQ19aj3tDr5cKKA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Peter Jones <pjones@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 May 2023 14:56:16 +0000
- Ironport-data: A9a23:36VewqtNODFW1mGspzm/k7m2COfnVD1eMUV32f8akzHdYApBsoF/q tZmKW+BOP2NYjP8coglbtjn80sPsMPXxoRnSANkryljRn5B+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Fv0gnRkPaoQ5AKFzyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwLzMdLTuqheGPwbeWeso9h8Q/JeqyI9ZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60boq9lt+iHK25mm6Co XnduWDwDRwAK9WbzRKO8262h/+JliT+MG4XPOThrq832gHJlwT/DjVITn2hm8K4gXeQfP1SD lYG1BswopoLoRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAYQTpRQNgnstIqXzss1 0/Pk96BLTlutrKSYWiQ+redsXW5Pi19BWUaTSYATAYDs5/vrekbghvRQ5BjGaiug9vdHTD23 iDMrS4iirFVhskOv42rrQ7vgD+2oJXNCAkv6W3/XG2/6RhiTJW4fIHu4l/ehd5KK5yYVR+Gp 2QenNaF7/EmCouEnyiABu4KGdmB//SCNjDHqURiE5ko63Km/HvLVYNX5it3KG9qP9wCdDuvZ 1Xc0StV5ZlOLD6pYLVxboaZFcsn1+7jGM7jW/SSacBBCrBheQnC8CxwaEq422H2jFNqgaw5I Y2cc8unETAdE6sP8datb+IU0LtuzCZuw2rWHMr/107+j+rYY2OJQ7AYNlfIdvo+8K6PvATS9 ZBYKteOzBJcFub5Z0E77LIuELzDFlBjbbieliCdXrfrztZOcI35N8Ls/A==
- Ironport-hdrordr: A9a23:A+AUDKjwIjOAh9QaMMBJVjknlHBQXuAji2hC6mlwRA09TyX4ra yTdZEgviMc5wx/ZJhNo7690dC7MBXhHPxOgbX5TI3CYOCOggLBRuxfBODZsl7d8kPFh4pg/J YlX69iCMDhSXhW5PyKhzVQyuxQouVvJprY4Nvj8w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHZjlmquto/3z2jNkiFi0kEFPQM+K9quqOAgAg19GA=
- Thread-topic: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, May 25, 2023 10:31 AM
> To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Ingo Molnar <mingo@xxxxxxxxxx>;
> Borislav Petkov <bp@xxxxxxxxx>; Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>;
> x86@xxxxxxxxxx <x86@xxxxxxxxxx>; Juergen Gross <jgross@xxxxxxxx>; Boris
> Ostrovsky <boris.ostrovsky@xxxxxxxxxx>; Peter Jones <pjones@xxxxxxxxxx>;
> Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> <linux-kernel@xxxxxxxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0
>
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> On 24.05.2023 18:05, Ross Lagerwall wrote:
> > --- a/arch/x86/xen/setup.c
> > +++ b/arch/x86/xen/setup.c
> > @@ -772,8 +772,14 @@ char * __init xen_memory_setup(void)
> > * UNUSABLE regions in domUs are not handled and will need
> > * a patch in the future.
> > */
>
> I think this comment now wants to move ...
>
> > - if (xen_initial_domain())
> > + if (xen_initial_domain()) {
>
> ... here. And then likely you want a blank line ...
>
> > xen_ignore_unusable();
>
> ... here.
OK
>
> > + /* Reserve 0.5 MiB to 1 MiB region so iBFT can be found */
> > + xen_e820_table.entries[xen_e820_table.nr_entries].addr =
> > 0x80000;
> > + xen_e820_table.entries[xen_e820_table.nr_entries].size =
> > 0x80000;
> > + xen_e820_table.entries[xen_e820_table.nr_entries].type =
> > E820_TYPE_RESERVED;
> > + xen_e820_table.nr_entries++;
>
> Surely this can be omitted when !CONFIG_ISCSI_IBFT_FIND?
>
Yes, good point. I will fix that.
Thanks,
Ross
|
