[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 09/15] build: hide commands run for kconfig
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 May 2023 14:12:04 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3RcKKWEFacIzy8yDKk3DXqhVvBvwGfBilpK60x0keR0=; b=ZYQZMT0/pQuldyzIoqkszwNo1hXjK5NCVMakjYRhWkgj/4C3G20bkciNXDxeBVmEgz0fQsXdl9SnyMQCO5P3k74TosyUEFhl2EyWe/+DNGfEd0VCPoWDGNqCD80UqBkbGcTqUdKo/EkLMsaDaxBSnOs/Mx33qEvBwb9au6mf40EQlj6NgMuMOlvIO3BwZVBgKMH+lnUfmUsx0YhKvAsTkH+TYhGOJejPPsW3A8ZQHTYGezup1aOny0NkZY4ZIP7ONP7ioQzGyOSqPXyhJcfzV9sBid4rNZJJSiYdEsLymREZ42FU5wbHDfe4x9ooC88h0OBJisAjpAT8kgj46hqOBA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpTZywnEYM4zbt8AF+0Y0tkRrcrKUH3RCakldnFud1TSBfgkZAub+J6L1+BEyom1GvSGdzJpo4zwR1ukiGQ15NpqHIgyz/W3KHns0nTpZSPSuLQFKZDUqqSm4Bb/tF08g97/9Jbw4RZC9lZ7E3LEKkS6uDYTrhC9olOH4II7Ov66oHgAXtKtGeix5d/RdbPUu45ITsjkNUxvbdH2HX/yIDS6rDR7rDVJklZWfzjH8Jbtd2knbyFbKsj17w7z1IWkqSELVgb7Z7epB5PGiUlE2TnKBZt+c3fH3A+FMuP4qRVYQYdzmPD2rxGxjcPvIPD/TJnutAILywfXK8BbcwZNOw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 25 May 2023 12:12:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.05.2023 18:38, Anthony PERARD wrote:
> but still show a log entry for syncconfig. We have to use kecho
> instead of $(cmd,) to avoid issue with prompt from kconfig.
Reading this description I was looking for uses of $(cmd ...) that you
replace. I think this wants wording differently, e.g. "We have to
use kecho, not $(cmd,), to ..."
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -382,6 +382,7 @@ $(KCONFIG_CONFIG): tools_fixdep
> # This exploits the 'multi-target pattern rule' trick.
> # The syncconfig should be executed only once to make all the targets.
> include/config/%.conf include/config/%.conf.cmd: $(KCONFIG_CONFIG)
> + $(Q)$(kecho) " SYNC $@"
> $(Q)$(MAKE) $(build)=tools/kconfig syncconfig
The latter of the Linux commits you reference also extends the comment,
to keep people from trying to switch to using $(cmd ...). I think we
should follow suit.
Jan
|
