[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 10/15] build: rename $(AFLAGS) to $(XEN_AFLAGS)
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 May 2023 14:17:31 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q7dVG7pTtKyNxCjXZNiKqOIYzPJo4XJd6QYa5cnCVZY=; b=d9km/pn11mzu/YnZodFF5ykQABYduUBIMxaLIan5UPoir18sAc2T4j+MBV+bTKh4/wNAWTxeawITgrDaSYLAmDJ2KVt2it5Zo2PFGDCPZD1xsPRyROaQBpsjdK9vzf+w2djJw9xnqYeiYKNWCxEbiDR1OO1EnJx697n6jK/iSwzNCh7zlBeJ/U4wfL/Id+U65qprrX8zVsQ50+uIwxDbfvChvk1vUx2QaGCI2VMxQrapCT4jr/deFQPEUXlaTvLO/cZyEo+7q31rJ+spWanaBAkOHqe7u8BtLTx9gRLQtF+xkqV1U2qWfkCnZKvl8T1HSjd21rcjdhQjhaKGNbg9Vw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gVtPJSTIwRlp0xDBAsYirNCP7y+6RE7/09YoTjhFSFWBMjr0sNPANrtLyABuv6AJQxanRigTv18PesiVRGNVL9AQ/Bz7JuqYCwqV7S11ELRS4nliV0zhlRsb+XNMKRqqfOf5Ga9WEfBV51Kme/s9yeHv5tNxsmpDAHk7AbDHhLfMziki9eNZV4q+4KVj8R9X4UdcLpqQqlVGGxifMdPSWpuu0XlklH4Gn3SPNNKRx6fMG6ras7pcsHpizeHfWhtnPeDzfH5VeBB7xWhtTchsvf8btP6oBR2urB/JEzbq8PP2VfMKSusPwXpm57ZBJR4boiYOwXoPM/Sb/C7JTST4YQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Delivery-date: Thu, 25 May 2023 12:17:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.05.2023 10:47, Luca Fancellu wrote:
>
>
>> On 24 May 2023, at 09:29, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
>>
>>
>>
>>> On 23 May 2023, at 17:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>>>
>>> We don't want the AFLAGS from the environment, they are usually meant
>>> to build user space application and not for the hypervisor.
>>>
>>> Config.mk doesn't provied any $(AFLAGS) so we can start a fresh
>
> NIT: there is a typo s/provied/provide/
And preferably with that adjustment ...
>>> $(XEN_AFLAGS).
>>>
>>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>> ---
>>
>> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
There is some interaction with the asm-offsets change, but I think the
two patches are still functionally and contextually independent (and
hence the one here could go in ahead of the other one earlier in the
series, with said adjustment made while committing). Please confirm.
Jan
|
