[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] x86/spec-ctrl: Rename retpoline_safe() to retpoline_calculations()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 30 May 2023 11:07:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D6j4RpVJk8+FiiDqdSbxE0XZO+TpLAYBU5hXPOIP34A=; b=FhP4QvB7R9Zyf2ZTsXBOVKg5rfY+u4HRN7E/UeDEVTmAGPPp2PyW1m8hEcFbNAFb3/cthnTDC0Ub6RnNX9bWQ+RtvPz6UAnL31ratf2APpjI4R6Jnw9efLIJdvTbFB1ABe1q1MzuLAMm+R4SYRykOQD/ogxfJXr25mqNWsa5VtffrEtp0331JrJBwBXRxb/WsIiYtG7tA3/v/QSJpcTOIzZJRHBtDVRQP/BPL9TNDup+4tbwRdv4ApjObzDesw4dMloUZxKxdMd8muPUgfoZL4wqjWm8ETKA5A0m+1UzZ7da3GR0G4FX46SW/OyyiEt19rxy/r/M/EvdPNqV9UHJ/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EQSAlHXlVeJmNKNRjOYxQeCuD7VQ4lhiUk8wckrfWCvyxqvUvn3aFo75SmLQJIqqQaL04jvYs1awg44uV+PmklRT5KBHBHsW2958l8YCvsAVK0d6w1rksH4d8ANU1LaXr5cOnPuKMf43lXUbv6r79zTwEKtwcjlMbrOUtvUZttjlTkjy79p9jQyKzCLhp8/3RcGQMUD61H1ADlij2QEjDQhgYsrSnVn4+aNkclibMym5O1MAevbhlWzweF4L+IEZgZjEsPu2kYl8LiymrZcKtkw2DM7n41F079QrsoDUxtfpwwj3s5uNGEHqXcAgc7iNw1X9AnZc3oLqExVtRqVHJQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 May 2023 09:07:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.05.2023 13:06, Andrew Cooper wrote:
> This is prep work, split out to simply the diff on the following change.
>
> * Rename to retpoline_calculations(), and call unconditionally. It is
> shortly going to synthesize missing enumerations required for guest safety.
> * For Broadwell, store the ucode revision calculation in a variable and fall
> out of the bottom of the switch statement.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
I guess subsequent patches will teach me why ...
> @@ -681,6 +682,12 @@ static bool __init retpoline_safe(void)
> boot_cpu_data.x86_model);
> return false;
> }
> +
> + /* Only Broadwell gets here. */
> + if ( safe )
> + return true;
> +
> + return false;
... this isn't just "return safe;".
Jan
|
