[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] x86/spec-ctrl: Rename retpoline_safe() to retpoline_calculations()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 30 May 2023 10:15:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bq/i3zi1iVB9iFkT2T3rezxP33svVrUAJxN3o0dVavA=; b=fJYMSc1iFJ+76FHR6ZW5YMYzykp5AcEd9ko+eHQQzNQirbaR74yKLegRC2pcNaxEdLS9MuvNUJpJqV3Mss39YTpR0Y4CpJ9iH1jW0/Eaold0Z6iNZtYXycMuH30Q7kzqsiYHIxof1M6pLDKAuaGCDstuHMNzAHkgFRL196MWRdUQjQ7w2k5IDqqgVw/7c0Rhtt+L6ZcUTT15M1G6kH69zDoPKll4Nq7hwiIT/CgyY3USYdBk8DTMoaDXIxjaZtFICZmQeFnzpXjMUuby2JDvZN8/p+lk0IDJWapeVEiBJ2vp4qAWlI2a0Q4UpIV34ncsudqPLRhQNZW+Ed634c8j2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFkIpiQXlk+zBS+wFo8ZRqtz1n7IVfFet11sryEKxXLs4ylJU9B7QxMnq49k0OYKqcyqufynThYp9vETpo7SiLB7xbeufQF2FIcdcWeqYjQvqBFjUwRgBKgA3G3ldUOjjNkO4KIg8PPHU2S6qVI93bX1on0eStd9wOU4ahAi9Ua+FEWd0zNzFNlBIYkXd2rF9myvnNS2TwB1Re4OhZsJxJYXqYxrKP3uSYf4Gb2hjjhUz2ycMkh3sjQkKrTCmLL/QF5ZmY/ptJBLGDyS47RUXJjP2dDTY5faF49csD2MnssMkcfDgP78H3SOoVRFMAWmvqIWJkNms93tjcj5KtwjTQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 May 2023 09:15:46 +0000
- Ironport-data: A9a23:apVXM6qd7D3DRSnMEQIXK6eaO/VeBmI1ZBIvgKrLsJaIsI4StFCzt garIBmGPKrcZjDzKYh1aIji/BwPu5bWy9ZqSAVkrSpmRHhG9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GtwUmAWP6gR5weDzCFNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABBUYiGxiqWX/LOcVuly3dp5B5fuDrpK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKKEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr6Y10ATIljV75Bs+D3KprvagtUuEe/1ND kgT1CBy/YoZ6xn+JjX6d1jiyJKehTYeUddNF+wx6CmW17HZpQ2eAwAsUTppeNEg8sgsSlQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PHmqYA3yxfQFNBqFfftisWvQGmvh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0=
- Ironport-hdrordr: A9a23:1CeqgqG984fIPvu+pLqEwceALOsnbusQ8zAXPiFKOH5om6mj/f xG88536faZslossQgb6La90cq7MBDhHPxOgLX5VI3KNDUO3lHGEGgI1+vfKlPbdREWwdQtsJ uII5IUNDQpNykDsS8h2njeLz/8+qjizEl1v5am856yd3AQV51d
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30/05/2023 10:07 am, Jan Beulich wrote:
> On 26.05.2023 13:06, Andrew Cooper wrote:
>> This is prep work, split out to simply the diff on the following change.
>>
>> * Rename to retpoline_calculations(), and call unconditionally. It is
>> shortly going to synthesize missing enumerations required for guest
>> safety.
>> * For Broadwell, store the ucode revision calculation in a variable and fall
>> out of the bottom of the switch statement.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.
>
> I guess subsequent patches will teach me why ...
>
>> @@ -681,6 +682,12 @@ static bool __init retpoline_safe(void)
>> boot_cpu_data.x86_model);
>> return false;
>> }
>> +
>> + /* Only Broadwell gets here. */
>> + if ( safe )
>> + return true;
>> +
>> + return false;
> ... this isn't just "return safe;".
Indeed they will.
~Andrew
|
