[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 13/15] build: fix compile.h compiler version command line
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 30 May 2023 12:14:56 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=khKxWV6/1WPbI++MA1oOZPouL9bJ2V5LBAoo5rhtt+Y=; b=FooT5WbCQzsf0IyeuaEOFSw7kmQIokBKRrKXfff8ItB6VZPcqmgs5McPFTMJ5gUMJQdK3DPFdFnhyoF75GlxiHCyfopJZ7MLc5bO/Ljcak7MMBf+NEruQ335I830ZL+4sijGgcVACl46csg0jY27yUsCHBt4XkIuGGfc/H1pxMpoI42QUYWd/hlORsCuXVSk11oGxhTp8GgGv1iVKpVlcOAwct4/AnNk/a9vBvk83IQZllvDlo+je6d1EQO0OfwuXJdtLCDKrZqN78yTsBPs874cYM2/kTqFg1P017GU3SwA9UcKD294WuYOXAQHaDdcsgTg90UXOKOwTWSDPGpfUQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+8CeIlpyn0JlKF3M8ScF62PFjnwWJKHKIA9YbOTBepKSmNSDiVYZBQXePtPqjcPCWTomXOkS7TUthTxjl7gbvBaCWBxdSUByF1vz3+ZNPPrdPvQpfG8Lnvkc9C8YLNzKspEQV3LpgbBUYMpFn5/dMrCtjrJ1i9oKb48GjugGO6PktQdLqN8atFuYQgbSDygZMtPJLlR2lTQiWLSAtPeC0dtxSGnITYF1FkrTPD2h4UNUjgCs1XL3Cyrv/A9jrqT/5nUaZpfWUnRQ52so6nfjpgJhHF+I03n7HfsIzz710R1eaunuWa2v/9evU1adB4REtkG8kOv308jxYFdbu8HFg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 30 May 2023 12:15:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZjZUfS+Hth9ncdEKi1WC1jlJ0EK9pLTuAgAl2xACAACF6gA==
- Thread-topic: [XEN PATCH 13/15] build: fix compile.h compiler version command line
> On 30 May 2023, at 11:14, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 24.05.2023 11:43, Luca Fancellu wrote:
>>
>>
>>> On 23 May 2023, at 17:38, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>>>
>>> CFLAGS is just from Config.mk, instead use the flags used to build
>>> Xen.
>>>
>>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>> ---
>>>
>>> Notes:
>>> I don't know if CFLAGS is even useful there, just --version without the
>>> flags might produce the same result.
>>>
>>> xen/build.mk | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/xen/build.mk b/xen/build.mk
>>> index e2a78aa806..d468bb6e26 100644
>>> --- a/xen/build.mk
>>> +++ b/xen/build.mk
>>> @@ -23,7 +23,7 @@ define cmd_compile.h
>>> -e 's/@@whoami@@/$(XEN_WHOAMI)/g' \
>>> -e 's/@@domain@@/$(XEN_DOMAIN)/g' \
>>> -e 's/@@hostname@@/$(XEN_BUILD_HOST)/g' \
>>> - -e 's!@@compiler@@!$(shell $(CC) $(CFLAGS) --version 2>&1 | head
>>> -1)!g' \
>>> + -e 's!@@compiler@@!$(shell $(CC) $(XEN_CFLAGS) --version 2>&1 | head
>>> -1)!g' \
>>> -e 's/@@version@@/$(XEN_VERSION)/g' \
>>> -e 's/@@subversion@@/$(XEN_SUBVERSION)/g' \
>>> -e 's/@@extraversion@@/$(XEN_EXTRAVERSION)/g' \
>>> --
>>> Anthony PERARD
>>>
>>>
>>
>> Yes I think Andrew is right, so I guess $(XEN_CFLAGS) can be dropped?
>>
>> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>
>> I’ve tested this patch with and without the $(XEN_CFLAGS), so if you drop it
>> you can
>> retain my r-by if you want.
>
> I'm sorry, I didn't look back here to spot this extra sentence before
> committing the edited patch, which as a result I've now put in without
> your tags.
>
No problem!
> Jan
|
