[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Fix incorrect taint constant
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 5 Jun 2023 12:10:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/kP0UtKA9AYAZnXd08SvLnj5O7FuCMB0eaRBOAxfS8=; b=KYLGglGRGbjpf4U3Zb8WWSFiV5KnaQAhUQ5WIR7Db+ARUNk7UnycQuF8Bv7MTzgr0PcJakKATcZhCsFT6mCpHXSt9gkHomTnDXhY9rttKI9033CNZnB8+i+y4yFbhZjuSqaFkd84eDehvibSMelAuyMr1eOGieE+QPj7zX6CJIVVWEva9SrXm/V+Bu/jGCKv2s6rkgJAhbypE/Zx4OD+Fo7lWz1PjPgnYiuHLivIh3xJee6aIOEwv9lLxNa3QitWnmeYNZWuS9QLlA/z3ap6AN8hlOsTC1SfV08mDf9nFlHTyHSr8GeyN6U4zT6gXaoNKU/oT8wA7uIizC/IivilCg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=anUNsnvhjE2X5/3/dwGuZAzLfZEocZjSkK1Z9GhuihLLXexhvDW6dNf3/qBmId9Thts327IsrIO54/DNLHXoyyvNvThjaGYppnm7RWmw2s96BJv+ELquLOSNc5ZTwV/5g3icn59iPpiJf2vhM3443HwanhRNbaSMdX5LRPuEemT2VcRX9EXZQVgu6S/BBvQ3OtWK1qIW0MXdkLSSkFlE5+ezbhI5czY/vVVOABTXwb36tswAzgIr4tLsEz5eeLSP42mORaHc0hvj1qL3DO+S9In51ZcFSm6DZJ+Hp9oMg9JSeF4hTGb2It5h3zfpgu1kqpgG3JFM4TONZ1B9SiPhyQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 10:10:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.06.2023 12:05, Andrew Cooper wrote:
> Insecure the word being looked for here. Especially given the nature of the
Nit: Missing "is"?
> sole caller, and the (correct) comment next to it.
>
> I've left the taint constant as 'U' as it's a rather more user-visible.
>
> Fixes: 82c0d3d491cc ("xen: Add an unsecure Taint type")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> I'm happy to change 'U' to 'I' if we think that no-one is going to be impacted
> by it. I just wasn't sure.
I agree with what you have done, i.e. leaving it as is.
Jan
|
