[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Fix incorrect taint constant
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jun 2023 11:14:15 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Dj10AEfkvdtDUJeiSOXu3e080Qt/twFOkcUr9+a6BM=; b=QoeM7UYTUEmLKjwNmxYG+m0CZGed3ns2Bdyn0sPZxEzs7oomRerhCFn5psLM1yuGbmei7W2EJ5xGw7JcmLsyoU6PmrxAG5aCD1s/DvhLf5M6WDeg6AVNWRNGe62ft3g8A4fR8g8+qYIPZ1nXroldb0Rp81bwoVnBOw8mLfSWTaqNxXhdxOuPEQw4dheWYK26FNtH3sKp5GIjjPLYUAL+PZwS5LYJs72CIc7e8906Ouc/g7oPcLhrLpJVQdjQU8fv5R5itO2HZBagIOW7EhfPg0bGLzpPJ/fTb8JtOMCtG3vzdZamWL8oOaGPCCwXAdCyeSme+Gjq1/Gzct8MXXGUwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bTzQcaHYH3pHngZrpKy0O/kh/HuG2K4V3vTLcnWFSlfbM4uLciiSDwJtKanm3byxQGUtTkdMcu63lNOXMhtMVkgBqvgoflLZ+UnsxKoBuK+LvXak/ZufnTOQtOLikEBnzQ2l4i0Gx0FamRKLeIL+7oOYnewkMAklmVtrzlkHUlWgDKiJQpPluHgaHbd1jPQgAfEzPAp/ayvrgbGkmk4BBVWtUlZ0DOHxR7n8FiXBZRfxkotncuFBeVt86RrWjv+22jiw2zC59Gg9PYneCRqW7Fr2FK4zsGaLAyPFi3bHWtAuRSX3+MEY31DDB6OEww+7LMXT//82z5yEkgy2r35jkQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 10:14:41 +0000
- Ironport-data: A9a23:vL2jwa72S2sgI0EMtcezJgxRtLjGchMFZxGqfqrLsTDasY5as4F+v msXWG3QO62KMWSged12Ot61oBtUsJfSyodkSVA5pSs9Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35JwehBtC5gZlPa4T4AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m/ t4aBj8pTDu53+euxKmrdNRDie0vM5y+VG8fkikIITDxK98DGcqGb4CRoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkkotjNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdtOTeXkrqMz6LGV7kk2ViAWCnS3m9ag20uRdNdPB 0s35QN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxmdLngJSHhGctNOnNQtWTUg2 1uNntXoLT9iqruYTTSa7Lj8hTGvPSkYK0cSaClCShEKi/Hdp4U0ggPKX8xUOqe/hd3oGhn92 zmP6iM5gt07h8MRy7+y+1yBhju2v4XIVSY8/ACRVWWghitpaYjga4G25Fzz6fdbMJ3fXlSHp GIDmcWV8KYJF57lqcCWaOAEHbXs6/PeNjTZ2QRrB8N5q2jr/GO/d4dN5j04PF1uLssPZT7uZ gnUpB9V45hQenCtaMebfr6MNijj9oC4ffyNaxweRoMmjkRZHONfwBxTWA==
- Ironport-hdrordr: A9a23:KPatD64p87pqjcx8rAPXwb2CI+orL9Y04lQ7vn2ZFiYlF/Bwxv re/sjziyWE6wr5AEtQ6uxo/ZPwN0819fZOkPIs1MSZLXvbUQqTXcBfBO7ZqEyFJ8SQzJ8j6U 4NSdkGNDS0NykLsS+Y2nj5Lz9D+qj4zEnAv463pRoCLGEaDNAH0+pgMGmm+w9NNXh77PICZd ihD6F81kCdkAEsH7iG7w4+LpX+TrPw5erbiCo9dlsaAUS1/GiVAHGTKWnX4j4uFxd0hZsy+2 nMlAL0oo2lrvGA0xfZk0PD8phMn9Pl691bQOiBkNIcJDnAghuhIN0JYczegBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5Tf9xgX61z4qynn6jXuVm2Hqr8DVTC8zT+BBmYVaWB3E7FdIhqAn7I t7m0ai87ZHBxLJmyrwo/DOShFRj0Kx5UEvlOYC5kYvHLf3PNVqwbA3zQdwKtMtDSj64IcoHK 1FF8fH/stbdluccjTwonRv6MbEZAVgIj62Bmw5/uCF2Tlfm350i2ECwtYEo3sG/JUhD7FZ+u X/NLhynr0mdL5EUUtEPpZVfSKLMB2dffuMChPNHb3fLtBZB5sZke+m3F03jNvaMqDggqFC2+ WUbLuf3VRCP34GQvf+qaGjySq9CFlUh1zWu4djDqhCy/rBrfLQQFm+oXAV4pKdSqYkc5Xmsw DaAuMYPxcVRVGeVbqhmTeOB6W7JRQlIbooU/4AKhuzi9PPLIvy8uPDNPvXPdPWYH0ZZl8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/06/2023 11:10 am, Jan Beulich wrote:
> On 05.06.2023 12:05, Andrew Cooper wrote:
>> Insecure the word being looked for here. Especially given the nature of the
> Nit: Missing "is"?
Oops yes.
>
>> sole caller, and the (correct) comment next to it.
>>
>> I've left the taint constant as 'U' as it's a rather more user-visible.
>>
>> Fixes: 82c0d3d491cc ("xen: Add an unsecure Taint type")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks, although I've got one extra hunk to add having just done the
other half of the taint work.
diff --git a/xen/common/kernel.c b/xen/common/kernel.c
index 14ce6b40ce06..ff67f00e41bb 100644
--- a/xen/common/kernel.c
+++ b/xen/common/kernel.c
@@ -344,7 +344,7 @@ unsigned int tainted;
* 'E' - An error (e.g. a machine check exceptions) has been injected.
* 'H' - HVM forced emulation prefix is permitted.
* 'M' - Machine had a machine check experience.
- * 'U' - Platform is unsecure (usually due to an errata on the platform).
+ * 'U' - Platform is insecure (usually due to an errata on the platform).
* 'S' - Out of spec CPU (One core has a feature incompatible with
others).
*
* The string is overwritten by the next call to print_taint().
>> I'm happy to change 'U' to 'I' if we think that no-one is going to be
>> impacted
>> by it. I just wasn't sure.
> I agree with what you have done, i.e. leaving it as is.
Yeah, I assumed that was going to be the preferred route.
~Andrew
|
