[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Fix incorrect taint constant
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 5 Jun 2023 12:37:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PLV3dCt8Dlwp6KOL+CBSEms15EEoF0AsjF47DfZ+bo4=; b=D7/jf8ULye8qtOl1H0H8FaKqe4SKT9rPREX3w096+IjCb0ED+WdJUenHi586e8ZTqkhA15gehm69U4KV2BNYxq5M+l+C8eeFlVkVGcZqrc5Lk8bXKwPJcp1N8QVQk8EZRVzo4Ylth8rL795lASw0IaPq6Cw8OmH0HA/AsdmILO3c9iaMZpOv4k37waf4OsXE9VyXQLhZhjwrp4fXmGPPJDDitcoaIIsbjnZC8iD9hRXb8lqz896ILtJtwl5o2OZfCNg2n2/50sjQBNck5XW3Mk5UA9Tdc+q7noz1RgfXiScW0CZcZrpws4Ye0bDABnye/39dVgAS7Vh+UFBHB9V3cQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sn3YBMB33yKtRZ6oliZtcp2Ykkw5S1LXCG+dXu4zrUBolVpuQ/BxKl2ICai4PRe+/kIBA4AypIrOPjSDUOe5Av9AT+MVM7FKQZrztpzsPiusWeAsmSofXNBSPJtychZPPwcbSxqeF3aIjh8gya+KxOz+kJ+zITJJPbTgxNqjZo3hnon81AioA8m7+ZV6w6zt/bJj98rUdB2WpkvdCZ76+cdyLcaVtnTOFGjB6FklkZSg7I3/L2BxKXQhWuED3I2UdAfCB++/BugUG3aTS6sBCUbcKabxwN1KkNfJbfGv4gCT/vkgUcaMA46j8kQ0be/RAiOiKjQFEgy1p/PKneTatg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 10:38:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.06.2023 12:14, Andrew Cooper wrote:
> On 05/06/2023 11:10 am, Jan Beulich wrote:
>> On 05.06.2023 12:05, Andrew Cooper wrote:
>>> Insecure the word being looked for here. Especially given the nature of the
>> Nit: Missing "is"?
>
> Oops yes.
>
>>
>>> sole caller, and the (correct) comment next to it.
>>>
>>> I've left the taint constant as 'U' as it's a rather more user-visible.
>>>
>>> Fixes: 82c0d3d491cc ("xen: Add an unsecure Taint type")
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Thanks, although I've got one extra hunk to add having just done the
> other half of the taint work.
>
> diff --git a/xen/common/kernel.c b/xen/common/kernel.c
> index 14ce6b40ce06..ff67f00e41bb 100644
> --- a/xen/common/kernel.c
> +++ b/xen/common/kernel.c
> @@ -344,7 +344,7 @@ unsigned int tainted;
> * 'E' - An error (e.g. a machine check exceptions) has been injected.
> * 'H' - HVM forced emulation prefix is permitted.
> * 'M' - Machine had a machine check experience.
> - * 'U' - Platform is unsecure (usually due to an errata on the platform).
> + * 'U' - Platform is insecure (usually due to an errata on the platform).
> * 'S' - Out of spec CPU (One core has a feature incompatible with
> others).
> *
> * The string is overwritten by the next call to print_taint().
My ack (quite obviously) stands with this further adjustment.
Jan
|
