[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86: Introduce arch_domain_teardown()
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jun 2023 16:23:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OtYR9OauQ4RZbWEochYiUuExjjDEb9q4MEedW6x5fxk=; b=ko8yy+gt47gx4oNxgS7zc+kw9eVMF/lk+iGWsCKwOcyrzhEGlE8Y07tROZkGHmAbhRCF6WfdWRDLtGyUa6GjLxhpy7c7HdiqgGSpw5QPitrSBBJg/otaRZZWGsWBWPmhSBR3EJabs6RRaVOmXZjAy+ydNQoPNMPaDNUBPhqMkf1+Fha/2RM7K9Pe7hmBogKEvdsT4tLmCJtuAKurk8LcoXiC8PYsl0MqfHOX5Lp/xwmUS3VE3wiP2NbgSier9quDsHQduuSvVq9NyYr5EpftijF7Sra8xTVI27H3H6XgKUzCB8Q2fpuumiL2xlD5YwuvkHptd32vgx/fP/KhbzlYnA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=haHss/eT9ds9TWQj10wSmoVaEjnMNBKobIjHsIkhTShZjMZFtibaV/BLHeoOkr/ba4dAspC1eLJNpS+B6+BHAzVlJKfzGW1HsCVBuhuHtjILtLiB/q51089dqpjJrdGXlJ+IwdPN7IZscC53Ul6r80Qkhht2LHD0AHwL357qZOrvJ8Fr6sVTUbhBLPVvJxnRJDqi2QECmGDosp4dQ+d8szGfB3pfgM5uMMHAukq8qrAeZrmRVkVhLhzLQC6T6wBuMt4zbEETUphw09I3fKeYKt/GBCDfetr1KUekMQW+CMVwYQK3VOLq61wbDDAA2SayKoxc6rsL864XdAwb3m8/ng==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 15:23:22 +0000
- Ironport-data: A9a23:E18tRaMK6H3JHdbvrR0BlsFynXyQoLVcMsEvi/4bfWQNrUokgzIBn WoaUDiOOq2KNjGne9xyPoy/9B4BuMeDzYBgSQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/rrRC9H5qyo42tG5gBmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0t97Mzxyy PkBFCAuYhHSvbun34uRUcA506zPLOGzVG8ekldJ6GiBSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PdxujCNpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eWxH+iBNlJRebQGvhCmwei/l4iBEwqVmTjsOWitkfidv9BN BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQP4MudIyRDcq/ kSUhN6vDjtq2JWKTVqN+7HSqim9UQAONnMLbyIASQoD4vHgrZs1gxaJScxseIa3k9n0FDfY0 z2M6i8kiN07s8kP0Kmq+EHdtBilrJPJUw0d6x3eWySu6QYRTISofZCy4F7Xq/NJNp+ET0Kpt WIB3cOZ6YgmD5yLj2qSQeYJFbel6uytNDzaiERoWZ47+FyQF2WLeIlR5HR7Ox1vO8NdITvxO haL50VW+YNZO2asYelveYWtBs82zK/mU9P4SvTTadkIaZ90HOOawBxTiYer9ziFuCARfWsXY P93re7E4a4mNJla
- Ironport-hdrordr: A9a23:VWIMKqDZtbdCUcrlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM NdmnFFeb/NMWQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/06/2023 4:19 pm, Roger Pau Monné wrote:
> On Mon, Jun 05, 2023 at 03:43:30PM +0100, Andrew Cooper wrote:
>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>> index 85242a73d374..854f3e32c00e 100644
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -589,6 +589,7 @@ struct domain
>> */
>> struct {
>> unsigned int val;
>> + unsigned int arch_val;
> While I haven't looked at patch 2, wouldn't such continuation
> information better be encoded in arch_domain in whatever way is more
> suitable for each architecture?
Well, it's filling a hole here on 64bit builds, which it couldn't do in
arch_domain.
And it's contained inside teardown{} which already signals it as fairly
magic.
~Andrew
|
