[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] amd: disable C6 after 1000 days on Fam17h models 30-3fh
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jun 2023 16:51:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cd34pS2Vcb7Em1RYW0o8JhQKB/mW8n31wq0doLL5p/4=; b=RtnA+lkAwGBhuHUHnD63drzz754Ph6KlWlUO233PPZ262f0c4H7mLXP1mqBP1VXMhyHBfCSD24RR4KVqtTYMP3O2Nyl1HiXucJ0tr7MHGvPyKon7e7E75FMGgJXkQRK9RnqApeaoTqLKBkkOBNkxma6TnBxstHNPuWAmTDN0lNGoRFIOOl4WE9wuaOxC69S+WRLAMtLwBobC9oSlYlVBed/569PEgjnleHA/h57dqTCw7Vl2SrGp7yksbVsdlaA8txI5lrHEkdLfMdHquXhxkHZmSrEbgc8Y85FuS0o6/Be1vSGbeAJA6aI1TW6eJLCg04ziVbMaxBtPjFXiZERxuw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m7jHu/UNnDOTbV729lLSARGaFXbTz68UZ5W/izL3ncz9ZmKkogJHSKMy+puAXrdf7EtSRI8qUUVr/lw3shga2lwEA/iic8MISDpWLvQMjrCbTBwofutOAY6Qq91e2+Ub4jL/GkRFqz9BKAiosq1AumNTK9br+Q7BUA2u4DQmmE8P10oLvGHN7kzb0TaxLSMtj6aCwYlhe5Kp22OBsPBRjh/rs1gIzLVusOhWPbCWzi44TSdtJ2AbGmN6NvRnQes6gIGCJ98yTS9BVCqxHG1IGeIx6xli4fgp5/H8S4HyXxuXGd46mZgGTuuU4TescWzeoPb25gwZWMBXKXJyDP8c0g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 05 Jun 2023 15:52:28 +0000
- Ironport-data: A9a23:vJtTzKCWtEroiRVW//3iw5YqxClBgxIJ4kV8jS/XYbTApDIn0DYBy TMbDGHXPf+La2H8etklYN+z9RtQu5+GyNRnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMs8pvlDs15K6p4G1A4gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw08Z3QkZn2 uAiJwskXiuiueuq8I+eRbw57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDS7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraWxXKkAdtMRNVU8NZwoF2Z6DASNSY0amSdpsSl2lXgQuNmf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatYrqcs3TjwCz UKSkpXiAjkHmKKRYWKQ8PGTtzzaESoIKW4PYwcUQA1D5MPsyKkolQ7GRNtnFK+zj/X2FCv2z jTMqzIx74j/luYO3qS/uFvA2jSlo8GQShZvv1qLGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWC3zaDw7FJG+yRxkOe
- Ironport-hdrordr: A9a23:G5noOqEZUhm7lzWdpLqE18eALOsnbusQ8zAXPo5KOGVom62j5r iTdZEgvyMc5wxhPU3I9erwWpVoBEmslqKdgrNxAV7BZniDhILAFugLhrcKgQeBJ8SUzJ876U 4PSdkZNDQyNzRHZATBjTVQ3+xO/DBPys6Vuds=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/06/2023 4:10 pm, Roger Pau Monne wrote:
> diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
> index 0d3143031b5b..728fa61a54bb 100644
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -1189,3 +1190,44 @@ const struct cpu_dev amd_cpu_dev = {
> .c_early_init = early_init_amd,
> .c_init = init_amd,
> };
> +
> +static void cf_check disable_c6(void *arg)
> +{
> + printk(XENLOG_WARNING
> + "Disabling C6 after 1000 days uptime due to AMD errata 1474\n");
> + amd_disable_c6 = true;
I don't think this is good enough.
AMD CPUs can enter C6 from HLT and IOCstate as well as via MWAIT.
You're going to need to modify the MSRs as described in the revision
guide, which will inhibit all ways of entering C6.
~Andrew
|
