[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 6 Jun 2023 19:16:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rcxIyhMVlgxl4huQci0IT9hw4zt/8fSTbZVgpMN8HVc=; b=dGP/f7grOdU96izQmGFq2OFmhRy3GysyoM9pPFI0qiL79/Px7YtzyNWObcjhq8FemzBDXIBrD5hYj+V50i3rpsSecA6gWzR7naZfo8i8je1ZUH3AGY3MQ62GhoGDDv3ymsAML/8Uxu0gdOpJrc4GTW7meTPBfEgRUn0CMV509hNfsx2hegkMU/m05Mm+qke9e+sX7opnNtf4RnWRId8vk39MIsFLDDx12l8/9QK6yyQMhTPBXLuVjoMe9KrBq7x4Vez9gXEv31lNW+bDdvH3lDRkmVnSyQ8geTCKjfPcLHIBkQniIY7ywKjNZKbUd0BbJvvd9I2V0maY6qvNEy37sQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ivoEb4DkA/m78FMI18ah5b4fR2yOb5G8A5kmt6NbQMF5S3gVs5C7PNoPNpF0IYn6LSKtAn91Ix1Xyp4eo4cAhe02f9/VXrzzU94OibO+LzDU3OTqvyekXBGq1YQlYMEmD8LRDJa4MWnmkrJHqnPsL3rUOy8gEVcpE5yHpj+18rxS2Td95dTy7O9voB2+fF9Hv5g9F0AM9J5wXDjN678XWBQoukdkuGWsW7bw+RUfpkLla8rtJ7JPQwBJ0oxmS7xrHAstw0S9doetD/3W9kxRiXscPtcehE1U5K6NOJ1+hVpRsNK2IyEriAoDXFYhYrSlHyRfvaFj2w6hu8Zx5JOtxg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 06 Jun 2023 18:17:33 +0000
- Ironport-data: A9a23:uC5qRqLZ5GehPFZ8FE+RUZQlxSXFcZb7ZxGr2PjKsXjdYENS1DVWy zcWC2uDbq7fMGD2KYxwaYqwoB8Cu8WEmNVmTFNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrbwP9TlK6q4mhA4ARgPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4sPHh+6 qYKAgo8f0HfntCNzIiLDdFV05FLwMnDZOvzu1lG5BSAV7MDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/RppTSKpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eWxHqrAtxPTuTQGvhCsAyQmWweETEvbwW3/9ulgUunZNJ7J BlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMc9qMY8SDgu1 1mIt9DkHzpitPuSU3313rWJqTK/PwAFIGlEYjULJSMP7sP/uog1glTKR8x6Da+uptTvHHf7x DXihBY5g7IfnMsazZKR9FrMgy+vjpXRRwtz7QLSNkqn5A5kYI+uZ6Sz9EPWq/1HKe6xUV2pr HUC3c+E44gz4YqlkSWMRKAIA+uv7vPcajnE2wYzRt8m6iin/GOlccZI+jZiKUx1M8ECPzj0f EvUvgAX75hWVJe3UZJKj0uKI5xC5cDd+R7ND5g4svImjkBNSTK6
- Ironport-hdrordr: A9a23:N2KzPK+BR2l2zvvxIbNuk+AoI+orL9Y04lQ7vn2ZKSY5TiX4rb HLoB1/73XJYVkqN03I9ervBEDiewK4yXcW2/hzAV7KZmCP1FdASrsC0WKL+Vbd8kbFh4xgPM lbE5SWc+eAamSTjazBkXWF+9RL+qj5zEh/792usUuETmtRGtBdBx8SMHf8LqXvLjM2f6bQEv Cnl7N6jgvlQ1s7ROKhCEIIWuDSzue76a4PMXY9dmYaABDlt0LS1ILH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06/06/2023 6:23 pm, Roger Pau Monne wrote:
> diff --git a/xen/arch/x86/include/asm/alternative.h
> b/xen/arch/x86/include/asm/alternative.h
> index a1cd6a9fe5b8..688b554099b3 100644
> --- a/xen/arch/x86/include/asm/alternative.h
> +++ b/xen/arch/x86/include/asm/alternative.h
> @@ -24,7 +24,9 @@ struct __packed alt_instr {
>
> extern void add_nops(void *insns, unsigned int len);
> /* Similar to alternative_instructions except it can be run with IRQs
> enabled. */
> +#ifdef CONFIG_LIVEPATCH
> extern void apply_alternatives(struct alt_instr *start, struct alt_instr
> *end);
> +#endif
Given that this is called by common code, it shouldn't live in an
arch-specific header, and it absolutely shouldn't live identically in 2
different arch's header files.
As this is a cleanup patch, we should gain a xen/alternative.h which
depending on CONFIG_ALTERNATIVE includes asm/alternative.h
This will help RISC-V too (a little).
~Andrew
|
