[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jun 2023 10:14:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1g3ISeRa7VRJey0FbHw9Y292xv4ZsdhCeKGZuofxBTo=; b=TJlig+ce7UQ9ZITf45xxDaxtOG1rxv/9+pxTh/gB+DqCetcTL082KBTjnJx2671GHmLJfGr4wXlluqYJk9hsL5VHNVQQBHBBaJea6PgSdnVpXU0/75g0y2oYBEoUvD41LCvmjRuhWgpIqapN5jYmgYCtUFegnNN1R9KsLOrBAAg2Mo5aUa3ZVM6nDo1vPn9dZoLNShBMhzjbqs5Ng5FOQCiuWowQvO7wpL2o3Df46nrmXmIDbUdgvI+ISo4Ovvv4Ja3stTBaZq05JPj0LB5xjFcFeDPOm867g9Kz58LR5tiNw/SIvG0DWTMfmqItGDb+TSExQX5a7WIXCvMaC9cI2w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PvKZdhS/cOOl44uWDeswD3xxO/XisYgkV/vDdRISXRMvUGFzjPIQO+HDtN3Ps5VG0x3Tyrv34IBEyuxhAyrOZ7Tg7ACKP+Nx/8nmM7h4iFpURjORC6QmwGmLTcoVJeHKE323LmI8+wOfaOXJT3b9+XygpleFWQ4DnMCcmypwqJgTHpIqBgkIv25+NSp2rXZCiXPbGfLIUTPh9sKUNphgfEWiJ24uXN8v92DX0dU3Sh47MRfGRmlxjyotFp7d/Vn7YUiHf5nKcblksv9zLZCY1nMjsaUeqo5gQxGYaeXQ0ogjf5YFrEVLrilZZ7joeaMOhKa0Tc4gU0lb46DFPLNjaw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 08:14:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.06.2023 19:23, Roger Pau Monne wrote:
> --- a/xen/arch/x86/include/asm/alternative.h
> +++ b/xen/arch/x86/include/asm/alternative.h
> @@ -24,7 +24,9 @@ struct __packed alt_instr {
>
> extern void add_nops(void *insns, unsigned int len);
> /* Similar to alternative_instructions except it can be run with IRQs
> enabled. */
> +#ifdef CONFIG_LIVEPATCH
> extern void apply_alternatives(struct alt_instr *start, struct alt_instr
> *end);
> +#endif
I don't see the need for an #ifdef on the declaration. We avoid such
in a fair number of other cases, keeping the code better readable.
Jan
|
