[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] livepatch: apply_alternatives() is only used for livepatch
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jun 2023 10:13:39 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AQuieCQht7QvH9PfzDBJ9uA2cMqJbgzwV1uDb4MegoY=; b=h7eAjaidmfmwH0z7BkUddBVt2FpAK58LScMrRWhhWkunMqj7rkrloEmy5uFNim6sGMyh5rxDttdjn5G1UWF0TCf+p6ufD7EkguZYq5lDG5oFcSTgxQp13qlCWIBUiXoVByODY7slwZxUhnNXIUJW9CVp5ZhXuFMhuc0xwv348edWZT0q5CWkpdjiyMiXHEbnDJNpKSzbGV190T9nKZSYCIttYzTZFEvwXr01dfpysV6LAP1GsQCb5q9GS5xPYiVriStPP64gQMFvQrwuNPvobcn3KadQnXz2P+E4rmlfTmfSDdPlnr/qYnaeRpZw9qtX6HxjmjzN6AoSmAEC7erwxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mcCn4mTusHjKvxYDaeV003VfWJaK/zNKSPgOqXQycWWkDE97z2Cxe4HYngShDOy+cXZ6M7GCNSuWF8cnuEg2MCnIiaWwBVSZGUu/6K8jisP5E4Je72Vi9t15A0nqUYXhKPGPCOv3obG1qHZ9FovYqBd5WpqLOCOgcSfM8wSP5TU85qDGg7b/HOS23Xwv6xUyeq3u40xAZg/2jwu4DkN16K5BIwYgN6kKaiD/ilorAneTSC++3sfbnHZDCCzLlSen0zeR+LGJ01118uBQX2CH/lQHeptNmFq2lroUPPlPI+12YyYNTSq7Um66rF6wof1c7Z6rCCm9B83Oe3w7X+tiBg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 08:13:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.06.2023 20:10, Julien Grall wrote:
> On 06/06/2023 18:23, Roger Pau Monne wrote:
>> --- a/xen/arch/x86/alternative.c
>> +++ b/xen/arch/x86/alternative.c
>> @@ -358,11 +358,12 @@ static void init_or_livepatch
>> _apply_alternatives(struct alt_instr *start,
>> }
>> }
>>
>> -void init_or_livepatch apply_alternatives(struct alt_instr *start,
>> - struct alt_instr *end)
>
> NIT: It sounds like the init_* was a left-over after commit 67d01cdb5518
> ("x86: infrastructure to allow converting certain indirect calls to
> direct ones").
Iirc this was intentional, to avoid the need for an #ifdef.
Jan
|
