[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][PATCH v7 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 7 Jun 2023 08:22:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=upMnOKCVzaIaFKEpiAVGbV0GOa0uq9d3oTgjDwd0WHA=; b=VsknEwlO3bAGzdEbJqI9Rwo2peYpsabcalx3mGq1sPc4u+a1vlvTMonUN5p5pu8auaqrp2VRkqZSWYrsb83r2uSIwyjak4lsC9GtH+AYudKZ69qz21Ga7ySi+VhkIhvSlOaR+kC8TpzHmFmH7eVHjILiq5P5Vg+y2WHpl/RiFe4fdq7X49bv4B1bu33xEbX2o01xHcU14TVNE7z8E6JyY+lUxyDpve6QKTTjvyUs9DhHLjts4nMHdThG6dv29M7kfi+9n/g7ixn2JzWrETP4eQk+0s54W+6ej34vn8eHqw0MoWoaQPbYvUpXGDpbvx4phngOFp/m05sxss5Il6XZHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9PK/JxVHRcfK554uMNZrqIx9QJLYEqrcL0ayVwOs+R+ZiR+DoKK73B16FN3LrySgduGOxeR7JOAS/sEo37fVh8B7SZemPEuBP/QYzcx7tW758ecb3oaNXjlkt5T9Od+H3+T1fvLErEC+E8BANFiJdTD8c7OoqgOtcXhAYxBR2FKn6y3ZMIJZNrDvKHT00Fh4ipfAwlqDS9DLHIbkNSbl8e9/eg9n7pjMQafTAoXNFcZKu8MRPIJ/8W635/d9S4V0IH0k3pwUlUhyaZ78Gg3bBVkz3WwDslL8wqQImmt+9ThNwplpaGxCQ6mH6MJd5Yp+SP/y4ximjQ/9HY1siMvFg==
- Cc: <sstabellini@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, <Luca.Fancellu@xxxxxxx>, <Henry.Wang@xxxxxxx>
- Delivery-date: Wed, 07 Jun 2023 06:23:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06/06/2023 22:29, Vikram Garhwal wrote:
> Hi,
>
> On 6/5/23 12:12 PM, Julien Grall wrote:
>> Hi,
>>
>> On 02/06/2023 01:48, Vikram Garhwal wrote:
>>> Add device_tree_find_node_by_path() to find a matching node with path
>>> for a
>>
>> AFAICT, the only difference in name between the new function and the
>> existing one is "device_tree" vs "dt". The latter is just a shorthand
>> of "device tree", so it feels to me the name are a bit too similar.
>>
>> From my understanding, the main difference between the two functions
>> are that the current one is starting from root whereas the current one
>> is starting from a given node. So how about
>> "dt_find_node_by_path_from()"?
> Thank you for the suggestion. This name was added in v3 as Luca Fancellu
> suggested to rename this function to "device_tree_find_node_by_path". I
> am okay with renaming it to dt_find_node_by_path_from().
>
> Luca, Michal and Henry: Does the dt_find_node_by_path_from() name works
> for you?
Works for me.
~Michal
|
