[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen: Fix incorrect taint constant
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 7 Jun 2023 09:04:19 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F64Mo46Eja+CcpQHdAyeauc/jy1QchVAqlyZ9Ot8T0E=; b=k1c84AQmT33IeFKV33ZdNkulLWpaqqLFgRgQg5w2tDJEkfrtr4OZJTZUZ3DRRBCY6iJdk8qtNsCBu1LrYPhP9QHSQcpxexaZCQpdTExaQiKhtudD1r8W8cC81n/POdXOdxuf9vT0GgX3xbKT03pE681SMpD4edWa+dbSwSN8VwRAf+hhy28YmkHlUhH+s0xSvI1yZhhKIlLrzFvM/DpyrvuaRgRgZ0B4MVi9duGUexVTc/HDo+73c7ItjZEp6t8tw8CIKNyA4oGzJKnl96d6d7gt8P87zNb4S5QGMSscFz+5nZXgj1Nv42xA3BTxblKNHX7z8xr3t2FxFgDJWgQouA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/JjqVspf8phfdg+n2mA9yh3FFnsWnm3Q5t7SCXY4SzvdX8K9l2FWQhHpaiG0XB/nIylebP/WeTDHIqBwsO2dzy0liq547+fC+U2OcsfxTzXjBgaRN6XVWqOI8BMESL38hTpxyTtIxLyiGL+Mqx8HeuOnOg+sZxHITDy/tzb2zbGvqSQnbCusqzlfqimB5lqsZ24X+H4DnJK6A8XaFktT1PeY9OCsoa2QLqknjLvotHC1bEfD5SuTqSJAS+RIHAjRHWJV/JAH7SK1KnZZihepJ2/YupHTCnm8qjjxKEwzDwNQjCpdt7AQlbMXB3Z5AhcxzGpI4r9CpfLrTkd/lxBxQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Jun 2023 09:05:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZl6An0ZVCR8BjEkS3vk0sA5g2C69+/+QAgAAEh4CAAApegA==
- Thread-topic: [PATCH v2] xen: Fix incorrect taint constant
Hi Andrew,
> On 7 Jun 2023, at 10:27, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 07/06/2023 9:10 am, Jan Beulich wrote:
>> On 05.06.2023 13:23, Andrew Cooper wrote:
>>> v2:
>>> * Fix commmit message
>>> * Update comment ahead of print_tainted()
>>> * Change the emitted char from 'U' to 'I'
>> Just to mention it: With this additional change I'm no longer
>> considering this applicable to stable trees. I realize that one could
>> argue that by taking it we could accelerate learning that we broke
>> someone (if anyone), but I'm not inclined to follow this line of
>> thinking. If Arm maintainers (seeing that only Arm uses this right
>> now) think they want the change nevertheless, I'd include it,
>> though.
>
> I'm not overly fussed. It's not hard to rebase around.
I agree with Jan here and I do not think we should backport.
This is not fixing a bug and could induce some misunderstanding if
we backport this change on a stable version.
Cheers
Bertrand
>
> ~Andrew
|
