[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86: Introduce arch_domain_teardown()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 7 Jun 2023 11:03:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4pVeP0uKucP8nRkF6l7VzLPXFFNp4GPvGtutR0D5kGM=; b=KzJYWSen/qZKffJ5NzHtAodF30ouwpcO0fxeq7eEkxv7tRldXBuwZnk46kwY8+Cenu37u4hzV7mbLBSnA65vvAfTSNYrEsME0GQupgkemFD1PB7/+Gly4daFZTWWutSlZIh1Fhb3O6uJuJ9Xv5xtIxvKzmCGTG2ND5jfaOAg7zXj2qFmkmaLIg+XIHZVN2VhEFv8gugWYv6wxoyi7ap28+kF1gAS7vV740ge/dBI3niC3pCV05njn33nQKhaHCx8+FpcI8ZQ3WNaq1iKUNFaoW51IybqWjnp0k4teAsbCmSzXmmCGI1DFghFFCr4Nycclj7ZiOf82Old2DAw/DqiJg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h+hIe3qnBbkIeOfgTJwcSDXmFzPGXAKzmDl5xgjwNOjqoYZntUhbg/1O8b8GKnzBmcOJOYC9AFlpr6AyM4BtmCMlBBvId40YgynOCb6QmQ8fxWP3N5tmS10MYJ16zY1wV4/zuy6rxWI9RepubCRKqDmnHNWnBVabpyvNm5RbVQy5wUtLuYxvvdZ56RGLBlaN0CJHv+vftndhM/2biMKLsUXmHWF9i6iYNUkB3qYFd1VqToNPDjOZ2vRuEz7aVAG1VMn/z0H7l+y3rRgmLV4lr9DXu/fcALlZsCcyxJs0KWwm2bVJEb5edpJ/z4hFKvijkJLcskkoCUTqm/KPWwv9nw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>
- Delivery-date: Wed, 07 Jun 2023 09:03:45 +0000
- Ironport-data: A9a23:2mWKK61T7MV8OehnPPbD5U1wkn2cJEfYwER7XKvMYLTBsI5bpzdRy GNMXz+HbqyONzOmf91/bN6x/RxXv8fSztA1TAY4pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gJmOqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfHEtgz s43cAoxMxGNqvyZzfWrbrJWr5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PlGSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv13LWezXqnAur+EpWd/fh22UOwl1BLVgczaFuZgeGrqVaxDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLSNrmK2YTzSa7Lj8hSipJSEfIGsGZCkFZQgI+d/upMc0lB2nZtR+FK+4iPXlFDe2x CqFxAAAgLEUgd8Oxr+M11nNiDKxpbDEVgcwoA7QWwqN5A5jeJSsYYDu7FHB9OtBN66QVFzHt 38B8+Cc4eYVS46MlyiERukABpmt5vCMKjqahkRgd6TN7Byo8n+nOIVPujd3IR4zNt5eIWOxJ kjOpQlW+ZlfemOwarN6aJ6wDMJsyrX8EdPiVbbfad8mjoVNSTJrNRpGPSa4t10BWmB1+U3jE f93qfqRMEs=
- Ironport-hdrordr: A9a23:cH3vz6DmHCZXh0DlHejHsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ++xoX5PwOU80lKQFmLX5WI3PYOCIghrNEGgP1+vfKl7balDDH5BmpM BdmsFFYbWfbGSS5fyKmjVQeOxQpeVvnprY5ts3mBxWPHpXguxbnnBE4kHxKDwGeCB2Qb4CUL aM7MtOoDStPVwRc8SAH3EAG8TTutHRk5riQBgeQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7hGhdf7zdNHJcqUzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iFnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjXuVm2Hqr8DVTC8zT5Mpv/MRTjLpr24b+P1s2q NC2GyU87JREBP7hSz4o/zFTQtjmEaYqWcr1cQTk3tce40Db6I5l/1owGplVLM7WA7q4oEuF+ djSOna+fZtaFufK0vUu2F+qebcLEgbL1OjeAwvq8aV2z9ZkDRS1E0D3vESmX8G6dYUV4REz/ 6sCNUmqJh+CustKY5tDuYIRsW6TkbXRwjXDW6UKVP7UIkaJnP2rYLt6rld3pDnRHUx9upypH 39aiIZiYZrEHieSvFmnac7vywleV/NEwgEkaplltpEUr6VfsuZDcTMciFqryKamYRgPiTqYY fOBHtoOY6dEYKXI/cu4+TfYegmFZBMarxghv8LH3Szn+nsFqrG8sTmTde7HsucLd9jYBK0Pk c+
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 07, 2023 at 10:43:24AM +0200, Jan Beulich wrote:
> On 05.06.2023 17:23, Andrew Cooper wrote:
> > On 05/06/2023 4:19 pm, Roger Pau Monné wrote:
> >> On Mon, Jun 05, 2023 at 03:43:30PM +0100, Andrew Cooper wrote:
> >>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> >>> index 85242a73d374..854f3e32c00e 100644
> >>> --- a/xen/include/xen/sched.h
> >>> +++ b/xen/include/xen/sched.h
> >>> @@ -589,6 +589,7 @@ struct domain
> >>> */
> >>> struct {
> >>> unsigned int val;
> >>> + unsigned int arch_val;
> >> While I haven't looked at patch 2, wouldn't such continuation
> >> information better be encoded in arch_domain in whatever way is more
> >> suitable for each architecture?
> >
> > Well, it's filling a hole here on 64bit builds, which it couldn't do in
> > arch_domain.
> >
> > And it's contained inside teardown{} which already signals it as fairly
> > magic.
>
> Plus why have each architecture duplicate the field? I expect none of
> the arch_domain_teardown() instances will remain without an actual
> use of the new field, mid to long term.
>
> I don't want to override Roger's concern, but from my pov
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Oh, no worries, I was meaning to reply I was fine with Andrews
justification, but forgot.
Thanks, Roger
|
