[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/4] xen/arm: pl011: Use correct accessors


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Wed, 7 Jun 2023 11:27:23 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JZbvHWkBcc8kAxTc1427ad6bE2o+h4yuG/qDarpDUxQ=; b=c+E7bMjnLdiI3wSXP5SRZwR7mlDuXJXgViS5wMTegv+O2HJGD0JlvjSZcNnHZ0rwA2XcFWUexc+UeU12KsrbMXTL74VliJ9rIovlpQsJfxW2WtdGRbSeul+7pnLfwF0TsUshRnf1YFRiiZd0HDcbvHPVr7PBDNKwBNgUoJ6DMKvauD72REcVkSZHJEDCbITU+fw2OFt43UG+oYyQSG2E23mYmTBfbrjEUBKaDI1QBUZv9AQmBK6BB4Wz3DGe8AbtmUNUGX21VVnsgOHRcc6y/zjhZbmhqLIgXnQPYWECm7DfeVpwx4cK1VkC49ZQrODp+6VTFemVELXlMzW5AjPjWA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSWQUHUtDYoz60l0jIfuqn9hy0453lsOQQZaaCMFhdB69ClRpQ20Y1B9AabYSnS5LpGFfbv67YCp6A0MUjwN0s4+hK+ojNIehcAu5beVEffPGJbFdGIsZtkqP45GzHVLOSfT/wivg+hUMjHcIfJZ70jZdUo88AzkTM+dkrihD3OchADuCFj1XJdQ670DzkoBq9IkitmC5MzhccivAROfKRb/se190SxH1l8Toum4hJnO0UAflgK3h+NC7ZXk9zDVhKTivj30QWnOe3zub1JUr28j0Ac7489W4MYBQoxVKonWwko9bLR3ScTAjsb76givuyViQqK/qMnWKGN5UByv8w==
  • Cc: Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 07 Jun 2023 09:27:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

At the moment we have a real mix of accessors used for PL011 registers across
early printk and runtime driver resulting in a) not spec compliant behavior
and b) inconsistency. This series:
 - switches to use the 8/16-bit accessors in normal case,
 - adds support to use 32-bit only accessors.

The behavior is now the same as in Linux.

The last patch adding support for SBSA UART in dt boot was added to make
the merge process easier. Also, arm,sbsa-uart property is usually present
next to arm,pl011 which would casue the pl011 driver to believe it is driving
PL011 and not SBSA, therefore resulting in accessing the registers that shall
not be touched (as oppose to just failing).

Discussion:
https://lore.kernel.org/xen-devel/b31a9f06-1ad8-b882-2fb0-84a84a1accb8@xxxxxxx/T/#

Michal Orzel (4):
  xen/arm: debug-pl011: Use correct accessors
  xen/arm: debug-pl011: Add support for 32-bit only MMIO
  xen/arm: pl011: Use correct accessors
  xen/arm: pl011: Add SBSA UART device-tree support

 docs/misc/arm/early-printk.txt        |  3 ++
 xen/arch/arm/Kconfig.debug            |  7 ++++
 xen/arch/arm/arm32/debug-pl011.inc    | 12 +++---
 xen/arch/arm/arm64/debug-pl011.inc    | 12 +++---
 xen/arch/arm/include/asm/pl011-uart.h | 19 +++++++++
 xen/drivers/char/pl011.c              | 57 ++++++++++++++++++++++++---
 6 files changed, 92 insertions(+), 18 deletions(-)

-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.