[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] multiboot2: do not set StdOut mode unconditionally
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jun 2023 11:45:38 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uNVouugmfcsIzMB9KzPXm+NCFnNeViitT7+nwpVyXEc=; b=WT7pW4SIAhRnBkbdJFT3bhhOO3WwMipZcOLpBENXCXOvv11KagMOGOx0Wg4GXW4k5ex7Zs15ePXDHarJ5FKXqFV3k7Iwi3QI3KpFrCB7j0cHO0p/TMe7CAjjHKSrfFrowJs4Wmm3YYJfb0SgG7LKmDLMUNJL8ksmWmbn1B3zOAQ5ZtTZ0mzf2of6ALJUF3WCtyAPvkhH1r/wgqVTrwwBy9XTt0BaVAcCZXQ+V7icru1kVXwm3TC4bXCoK3N3JEwUjNQ4zr3YUiGxJh7sXjIsA0f9bPdW1m6UsnYv9RMRYgCUMHdALuz27yYFyJkoQg7rGy50aYFVRbSLGAgycggEBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RbdRtPOZ1u89hqx/+u9A8/Vn+qud80V4jcjofjpKFsG9KjFGrvViRB0ju5GOipXVD2j9CNLI8585OT+23U1czlvPZg+h+lLdLy2xGLIkLjImPObI8B64AvxC8GcO5hEbJwkewDK44G/Rmygs7jY0budoK8k+K8Tw0rsBZVK6Pp3iYXICn2l/h1Fd8aafpf2uxv+ZBCK6AdC9iWvglyWEq2cy+tC3TaLW6fK8Fib/VHbwbrbbJKn/Z7IO/zKveOBDruS2HmnXsIdJ0eQdQScePfOXdnwehBIEhcd3wj21OIGC25F7UkXDb545S5MOc9kprtYQv1Io4dR8wuDXz9BKpw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 09:45:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.06.2023 15:05, Roger Pau Monne wrote:
> Only initialize StdOut if the current StdOut mode is unusable. This
> avoids forcefully switching StdOut to the maximum supported
> resolution, and thus very likely changing the GOP mode without having
> first parsed the command line options.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> The code is very similar to the approach suggested by Jan, please let
> me know if you would be OK with your suggested-by tag added.
I'm okay either way; I only suggested the "how", not the "that" after all.
In any event
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
