[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] cmdline: parse multiple instances of the vga option
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jun 2023 12:07:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7aSI9lSvPAdTvYt8KMrXmfa1BHJy5GIgor8Sau9mKbI=; b=DO9sNXFpSozg8oRiZ8Us7e1Yoz1arN+OzAZflkaCN6I4x0/Ax4029jG8jF9/zge6hBwicYLRm2Zh0nqL+MdIj5hU2YdGIZ457rnO9N0Tn/G7Z6NAQULOK6XdV7MzG0Ey95M0i5ICw7v4qryO/eEW1BPbVAOWUyF8aa0PdrAAN4Fny6X/yqyu/QGpH3+sPVob+k/YLcp24/uxW9ER6wk1Yjs6ARp9Drpwtf3fftw0P/QLrPt6Dy4OUHlLZj7aELDop/ttXrMMYE9s2/ZXEVugi6vG0rW9ohY9C0clr0AeKb/63zun9gessdbljhXdjSOAhW4q6/rOLPcY8QA/CvHMlw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQXO7hXRy46jMaL7laowhsvZPOqSh4EXdHRKiaWT4uDpmIB+oHiXk1gKf4bvKISWCba5AEZzpCxW9NklKPgqTXMCVEPvKjdaP8f5IJCZxtANVE3RXpx94HVwRDcq5qSRAKh6W7xM5JiuMO60PdSRHamb6dnSL6VJxC42Dcy/5WcqmMXM6SHx08fnlAh8ZCL7geetwZn6jKOB2M9a6+bswsLXTonnuta5w4SVvEM33q65k13IOteQk3uPfHClT2Fwu7rnKy/9pNc1IhHsYR4+JjPAykX1eshbRBU3u89UMWaabloYymmZGjeCofymaiXthOKKvyFsmbOCXGOjXvK3aQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 10:08:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.06.2023 15:05, Roger Pau Monne wrote:
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -2628,6 +2628,9 @@ with the specified width, height and depth.
> `ask` option. (N.B menu modes are displayed in hex, so `<mode>`
> should be a hexadecimal number)
>
> +Note that all the occurrences of the vga option in the command line are
> parsed,
> +and hence later occurrences can overwrite selections done by prior ones.
I'm not a native speaker, but is it perhaps more "override" that you
mean?
> --- a/xen/arch/x86/boot/cmdline.c
> +++ b/xen/arch/x86/boot/cmdline.c
> @@ -277,59 +277,58 @@ static u16 rows2vmode(unsigned int rows)
>
> static void vga_parse(const char *cmdline, early_boot_opts_t *ebo)
> {
> - const char *c;
> - unsigned int tmp, vesa_depth, vesa_height, vesa_width;
> -
> - c = find_opt(cmdline, "vga=", true);
> -
> - if ( !c )
> - return;
> + const char *c = cmdline;
>
> - ebo->boot_vid_mode = ASK_VGA;
I think this needs to stay here along with the addition of the related
"else if" below. Otherwise I expect behavior for e.g. a sole "vga=keep"
on the command line would change (in no longer prompting for the mode
to use).
Jan
|
