[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] cmdline: parse multiple instances of the vga option
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 7 Jun 2023 11:16:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SrwK6+fhZcohYE8jUc1dakYfq8Ws9LON8Axv9ZQrpRY=; b=VK3T92h05Ni1iD5BsGlbiAsS5e/1NHj9Q4gn0zw52C6hFm8E+JPZsQFLlHeREsWo3AW57Wd86KAueDh1DaTWUdL9Iu+ulM9bK5z5txwoYqJTGPGasTQJQLMORhuzrsf951dQEan+LMU0qUHqy97nIrKgBfcJctogmpmqjoNCmpb/oTuvauTDmNuC6QeF2EgU0fbvm2SOGqcunCxLseJq4lZAx/vYSJmMv+Y6mc0Jmsm9OATNpChUcvIXUr7bV1oEoE9WBIXtzrDtDSuqkQOWyAdRo4clQwDm7D9DULjngMgV+p+RYm3jSpfkg4DmUcieYN0YO/9xgTmjfT42OW8G0A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dvt8SGQ+Pu8IMlGyq/FoNlD4F+N0JCOH5F6nAJabVpvXc/N6e6CdpJRcb93IHknWNiY5Rj5kNWgfAwWlakhDgHVt6oeTA0oFh6WEV7QAQPHZXfTiidrGeeAHQA2bb3SWhWyCQWXnntBeCbCAP2if+zY5ZeqJgfT23xJqo07fgShZemi6YTF5o2Mr7pT8jka1ZGj8SF5SiL0bCujm5Q40pteusZmj1P1qTIFfjTID0emu4+wsbCk2DJgq+NO6IRdVlpVTW+CXlQbD15XZ30Y3xhakSCHaAbt0uzFJcGTtzR79gA+6N68WPrm6XZii9JxC47KpxbT/AMrox+9buYOhZg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 10:16:35 +0000
- Ironport-data: A9a23:vwXWz6l1zOo+WahUkKWtLEvo5gxUJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJMCDuAbvaJNGKmc4x+PITlpx9Q75XXzIAySQY+rCtjFCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5KyaVA8w5ARkPqgV5ACGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 cc8cTNScTGDvtj1npmVQdJSnochN+C+aevzulk4pd3YJdAPZMmbBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3ieC8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTefjrqA33Af7Kmo7Fx8aaWaKuueFuhCbZf1Zc EZO3DYXlP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xBHUATzNHQMwrsokxXzNC/ kSSg9rjCDhrsbuUYXGQ7LGZqXW1Iyd9BXAGTT8JS00C+daLiJE+iFfDQ8huFIaxj8bpAnfgz jaSti88ir4Py8kR2M2GEUvvhjutot3FS1Az7wCOBma9tFohNciiepCi7kXd4bBYNoGFQ1Kdv X8C3c+D8OQJCpLLnyuIKAkQIIyUCz++GGW0qTZS81MJrlxBJ1bLkVhs3QxD
- Ironport-hdrordr: A9a23:qHY1H6HeZzNOTA3GpLqFBJHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6La90dq7MBfhHPlOkPQs1NaZLXPbUQ6TQL2KgrGSoAEIdxeOjtK1kJ 0QCJSWa+eAc2SS7/yb3ODQKb9Jrri6GeKT9J7jJh9WPH5XgspbnmJE42igYypLrUV9dPgE/M 323Ls6m9PsQwVgUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZrzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9EfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZzyHtycegH2w 3+CNUaqFh/dL5mUUtDPpZwfSKWMB24ffueChPkHb2gLtBNB07w
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07/06/2023 11:07 am, Jan Beulich wrote:
> On 01.06.2023 15:05, Roger Pau Monne wrote:
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -2628,6 +2628,9 @@ with the specified width, height and depth.
>> `ask` option. (N.B menu modes are displayed in hex, so `<mode>`
>> should be a hexadecimal number)
>>
>> +Note that all the occurrences of the vga option in the command line are
>> parsed,
>> +and hence later occurrences can overwrite selections done by prior ones.
> I'm not a native speaker, but is it perhaps more "override" that you
> mean?
I don't think this is appropriate to say in the cmdline docs. Absent
bugs, all command line options get parsed left->right with
latest-takes-precedence.
It is a bug that vga= didn't behave like this.
It might be ok to say "Note, prior to Xen 4.18, only the first instance
of vga= got parsed, with subsequent instances getting ignored".
Explicitly calling out the default behaviour in one option does nothing
but confuse things.
~Andrew
|
