[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hvm: print valid CR4 bits in case of error
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Jun 2023 16:00:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=riGuLPKZzej+EH/OSBAvKcqPD21wGhsOdJJjNaisKXo=; b=mTwur1gGEeMeaf5I+A2GtkWA/L5tc6nAnlb84fiStt/zioKnzVpb7xeZhUqDm/BzIK8acCFI18sHRuVu4RpkoY5StyzN6NPRov3aAQzkPUNzy1Ms2/tJSxJS5vtLj3F1JAHkaJQeL8h9AHJSVlN1B/xw0xzYtxdJPRP+fq7MVMv7By3F3gRVjhH2p8xQ/nriLCBc/q8f5wfYjyZSU6Bxlheokg9M0BVDkLLY/on/zp1dD9027mByIHeY24BXUX7nOkRf5ljbt8agUB/dSyM3Q+Nm5T8rcZu3KujKgy0KC46kUo2Ngup317V/vAeBXX+SZ+62K30lqlWrmUctbtDngg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AIOnB8bAhdTwu3jqHJBQtU43UihaPhVwcCAZq8lXs6BeupIyFJppQfkUnztbcklCsTX69592isNGlBNgL58nADUxvEBvqUMUFJNKkN4r0fZlWKGu0WFOBuxxxdJpgBfQQMiSezZMWDaRabYYnENBvKcYUbqqLZz2yDhrHjNyhVaWhnjm3bxzDbhs5bvyXm+BTy7ltIdpRM92CPZYMC11pQdDX+lVRSf8ON3dTfOoLfo2Oj1F7tcEzDxGNWUj228XJBtUAJ7IHvIlICfIH38GN8OhWfOiaBPGFqzADWIJrNm23QZNc05IRst93Xhyo6SY3J6XmVEuwr55xN0BtqKH5g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 14:00:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.06.2023 15:46, Roger Pau Monne wrote:
> --- a/xen/arch/x86/hvm/domain.c
> +++ b/xen/arch/x86/hvm/domain.c
> @@ -266,8 +266,8 @@ int arch_set_info_hvm_guest(struct vcpu *v, const
> vcpu_hvm_context_t *ctx)
>
> if ( v->arch.hvm.guest_cr[4] & ~hvm_cr4_guest_valid_bits(d) )
> {
> - gprintk(XENLOG_ERR, "Bad CR4 value: %#016lx\n",
> - v->arch.hvm.guest_cr[4]);
> + gprintk(XENLOG_ERR, "Bad CR4 value: %#016lx (valid: %016lx)\n",
> + v->arch.hvm.guest_cr[4], hvm_cr4_guest_valid_bits(d));
> return -EINVAL;
> }
>
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -1018,8 +1018,8 @@ static int cf_check hvm_load_cpu_ctxt(struct domain *d,
> hvm_domain_context_t *h)
>
> if ( ctxt.cr4 & ~hvm_cr4_guest_valid_bits(d) )
> {
> - printk(XENLOG_G_ERR "HVM%d restore: bad CR4 %#" PRIx64 "\n",
> - d->domain_id, ctxt.cr4);
> + printk(XENLOG_G_ERR "HVM%d restore: bad CR4 %#016lx (valid:
> %016lx)\n",
I'm not convinced printing a lot of leading zeros is really useful here.
However, if you switch to that model, then all uses of the # modifier
need to go away (in the earlier instance it would be nice if you also
fixed the pre-existing issue then).
Jan
|