[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hvm: print valid CR4 bits in case of error
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 7 Jun 2023 16:24:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZsqxCh9gvftqPvjISefLsroxBhpp/2yePn/eDeXSnm0=; b=F2MlJ0mQ82d6R1bL750pkAWtVFUk6gi0xW/hxogcgqw+I1plqLS0kG2jHXW32NhPWEec8UsuVuUzogO1P7N8LW4bJLFK131kKifGaqjO57XLx4ET+uqqxTvfrncwW3m7Tt04DyHGSRs5Nupouwi/n5nve9VAAeKMVfYF2EUNCoV6xvI931BdHHRB8pfg7HVRCVY2kH4CXy25qgfqXi5L+zFOL7TksyNO4nvy7rtQI3Hm8Q1NeJ0A9AuBOYtV1wgJjm4+Qmr4xuf6KSBkAcpcC5Jp+IAjWYL8hzEDqM15s9+oo5qQ/Ve2VG8TuBdkSzFJRS3TG0p9/IMqI/vF86VRBg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RR6z1+p8Ce4x5bvEUfTajh/8+DTzWMA9qwbThNFDfiJe0WynFnN1e4e05ZhITrVxhJU2ufcNS29JJ64uA2+oZcZsZC2CjrRiuMRwJwKH/3qH2ZhyDxWhn0dSBmA2tYeDd9PlKSXMnZABiXOzGy6M9k+SBfK4bNSFN6TwsHVbZ8ZFXNwd2O7nxRiD4T0ENir4YeGm3rrTeWbRtjiTA7YAT6sOLVACqwhVnap/gVKtXZZIcIk20FlnQw4zUyxK7h1OMaOaK2VDoLbk2rSNDGn3wco19DTkmfCRXYol+EHjCdn+jJWyh55mU2P5c94nX14Tj8OPM+xUsXvaOncAFxRbTw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Jun 2023 14:25:10 +0000
- Ironport-data: A9a23:6yD20av2U0fo/G+uGBHSs1jN6efnVHBfMUV32f8akzHdYApBsoF/q tZmKW+DOf+DY2SjLdp/PNuy9E0O7cDWz4BkSwJrrSo0ESMQ+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Fv0gnRkPaoQ5AGGyCFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwch8Qc0Clqb2PmOziEvt23s4bEcasI9ZK0p1g5Wmx4fcOZ7nmG/+Pz/kBmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osif6xbrI5efTTLSlRtlyfq W/cuXzwHzkRNcCFyCrD+XWp7gPKtXqiAdJKReDjqZaGhnWC6mItAUBOcGCb/+C4g1GZXel9O hQtr39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLL5y6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9EIMZTSoNTA9A6d+6pog21kjLVow7TPDzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGEhRqcBO51lmW8g UU=
- Ironport-hdrordr: A9a23:3nTdta/MWE8TNXcPY+Zuk+DqI+orL9Y04lQ7vn2ZKCY7TiX8ra uTdZsgpHrJYVoqOU3I4OrwW5VoIkmzyXcK2/hyAV7KZmCP0gbFEGgF1/qH/9SKIU3DH4BmpN 5dWpk7JNrsDUVryebWiTPIa+rIGeP3l5xAU92uqUtQcQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 07, 2023 at 04:00:14PM +0200, Jan Beulich wrote:
> On 07.06.2023 15:46, Roger Pau Monne wrote:
> > --- a/xen/arch/x86/hvm/domain.c
> > +++ b/xen/arch/x86/hvm/domain.c
> > @@ -266,8 +266,8 @@ int arch_set_info_hvm_guest(struct vcpu *v, const
> > vcpu_hvm_context_t *ctx)
> >
> > if ( v->arch.hvm.guest_cr[4] & ~hvm_cr4_guest_valid_bits(d) )
> > {
> > - gprintk(XENLOG_ERR, "Bad CR4 value: %#016lx\n",
> > - v->arch.hvm.guest_cr[4]);
> > + gprintk(XENLOG_ERR, "Bad CR4 value: %#016lx (valid: %016lx)\n",
> > + v->arch.hvm.guest_cr[4], hvm_cr4_guest_valid_bits(d));
> > return -EINVAL;
> > }
> >
> > --- a/xen/arch/x86/hvm/hvm.c
> > +++ b/xen/arch/x86/hvm/hvm.c
> > @@ -1018,8 +1018,8 @@ static int cf_check hvm_load_cpu_ctxt(struct domain
> > *d, hvm_domain_context_t *h)
> >
> > if ( ctxt.cr4 & ~hvm_cr4_guest_valid_bits(d) )
> > {
> > - printk(XENLOG_G_ERR "HVM%d restore: bad CR4 %#" PRIx64 "\n",
> > - d->domain_id, ctxt.cr4);
> > + printk(XENLOG_G_ERR "HVM%d restore: bad CR4 %#016lx (valid:
> > %016lx)\n",
>
> I'm not convinced printing a lot of leading zeros is really useful here.
> However, if you switch to that model, then all uses of the # modifier
> need to go away (in the earlier instance it would be nice if you also
> fixed the pre-existing issue then).
Hm, I've got those messed up. What would you be your preference then?
(%#lx?) I would be happy with that also.
Thanks, Roger.
|
