[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools: Move MASK_INSR to common-macros.h
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 9 Jun 2023 11:06:25 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l3oIEoC83UskXLNO9RkeGsekOzRadA5EOva+PTLNrb4=; b=cMZd4d5fxQL1mXPPIi9e6lCoHxEdvtogbwiTrtqUYkP/PqeB7PE8geI9Apl0QkTleO+TTvOo9a4HH3VzckMWbxvAyGFtY3loyrxI2hLKL93SKNLJxE/cywwL9IO4x9EmAR4jWDJJ+xy72NqCiO6PecJvNtFKQ+nAna4WrPjl3O0BXTRR1T0kkbk3erazRQSCTVjjMD+a+FaQ3j4ATYk3YvqaE7n7yGXBGjXxxoRPZSINYbX7AlQ14IIBDfosT9FEQll+DVj4mkIqo/WS1cNiV98EIb/rKecbQ7B7LLZ1R2QEzO6qHVzAh7ma6rbd5VPLvZf0HwEFVjM2p8AMPGYjrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jwlq9jY4Urt+GmMpvHddZ777JOv5G6biVmURn1p/piEcASMd125xaXzsNO4uv4bSjqnBVwB+krvh1GPcjE3UNVJXlYvJ3x0ZIu+Ar4Hae+hjc/EuSQrOzrxFD6Y9I3YBm/Kd7g2CwSs8nuHAoU3zKHOt1vVbc5tJgx6e/gvHjuyLWQZEOdOft5q1HiL7pSiEI+ag5tI3m+hjF7YAK5nJOC4PUGx1aO71IWltcNh3Zcld/DfYsyKVcq5Rk2KIwtefqGlsCY2vzhhoHwfLYLDFbJuT6VGb6LaK5ttDfzGkA+Bu7K8u8YcAWAimmiuVPHDlnwgiP42i9fUyUDTcqdwsFw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Fri, 09 Jun 2023 10:06:59 +0000
- Ironport-data: A9a23:pLX6tqn6hfZUOxV10iSNwT3o5gy1J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXWmuCPv2JNmPxf94lb4u390xXv5XWz9NiTws/qHszFyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5KyaVA8w5ARkPqgV5A+GzBH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dETLQEJUEG5u6Xs0p7qR7JUicEKE8a+aevzulk4pd3YJdAPZMmaBo7tvJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVI3ieezWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTeHnrq4x0AP7Kmo7VA1Gexyek/2DiEu4d+MHD kgVpQ8Wov1nnKCsZpynN/Gim1agoxUVHfRZFeY37AWQ4qPO5kCSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaOycPKnQZTTQZVgZD6N7myLzflTrKR9dnVaWy19v8HGipx yjQ9XdgwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBd8yRCxIji1a2wqRE=
- Ironport-hdrordr: A9a23:1WMM46ilrEReI/B7pqCQQkmR+3BQXh4ji2hC6mlwRA09TyX5ra 2TdZUgpHrJYVMqMk3I9uruBEDtex3hHP1OkOss1NWZPDUO0VHARO1fBOPZqAEIcBeOldK1u5 0AT0B/YueAd2STj6zBkXSF+wBL+qj6zEiq792usEuEVWtRGsVdB58SMHfiLqVxLjM2YqYRJd 6nyedsgSGvQngTZtTTPAh/YwCSz+e78q4PeHQ9dmca1DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/06/2023 8:37 pm, Luca Fancellu wrote:
>> On 8 Jun 2023, at 18:40, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>
>> MASK_EXTR() and MASK_INSR() are a matching pair. Keep them together.
>>
>> Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for
>> Arm")
> I don’t think this patch is fixing a bug:
>
> ### Fixes:
>
> If your patch fixes a bug in a specific commit, e.g. you found an issue using
> ``git bisect``, please use the `Fixes:` tag with the first 12 characters of
> the commit id, and the one line summary.
That a poor explanation...
Fixes: is about corrections to the patch, not bugs.
56a7aaa16bfe is unlikely to be backported, but if a downstream were to
backport your SVE patches, Fixes: identify all other patches they need
to take.
Fixes: was specifically invented to let tooling (partially) automate the
task if finding new patches to backport, based on what had already been
backported.
Concrete bugs are the majority reason for a Fixes tag, sure, but not the
only reason. In this case, a downstream absolutely doesn't want to get
into a position where these macros aren't together in a pair, because it
there will be a case in the future where it causes a build error.
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> But it makes sense, so
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Thanks. As you've already indicated that you're ok with fixing up
x86-emulate.h in v2, I'll retain this.
~Andrew
|
